1176337 - Remove unnecessarily gcc-4.4-specific cast from nsTableRowFrame::ReflowChildren(), now that we require newer gcc

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Daniel Holbert [:dholbert]]

Right now we have this in nsTableRowFrame.cpp:
> 892   kidReflowState.emplace(aPresContext, aReflowState, kidFrame,
> 893                          kidAvailSize,
> 894                          // Cast needed for gcc 4.4.
> 895                          uint32_t(nsHTMLReflowState::CALLER_WILL_INIT));
http://mxr.mozilla.org/mozilla-central/source/layout/tables/nsTableRowFrame.cpp#892

That "gcc 4.4" thing stood out to me. It was added in late 2014 to address some bustage on B2G, discussed in bug 35168 comment 95.

But I don't think we need it anymore, because we require newer GCC now.

Quoting https://developer.mozilla.org/en-US/docs/Using_CXX_in_Mozilla_code :
> [...] as of Mozilla 38, gcc 4.7 is required on all platforms

(Presumably "all platforms" includes B2G.)

Comment 1

[Daniel Holbert [:dholbert]]

(Note that bug 1174700 is touching this region of code; we should wait to fix this until after the patches there land, to avoid bitrotting them.)

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Remove unnecessarily gcc-4.4-specific cast from nsTableRowFrame::ReflowChildren(), now that we require newer gcc

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8625341 [details] [diff] [review]
Remove unnecessarily gcc-4.4-specific cast from nsTableRowFrame::ReflowChildren(), now that we require newer gcc

Thanks!

Comment 4

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc4d79e8bad8

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fc4d79e8bad8