1176359 - Fix Windows checkout issues for Firefox UI update tests

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Armen [:armenzg]]

http://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/39.0b7-candidates/build1/logs/release-mozilla-beta-win32_beta_update_tests_1-bm86-build1-build0.txt.gz

21:09:45     INFO - #####
21:09:45     INFO - ##### Running checkout step.
21:09:45     INFO - #####
21:09:45     INFO - Running pre-action listener: _pre_checkout
21:09:45    ERROR - Exception during pre-action for checkout: Traceback (most recent call last):
21:09:45    ERROR -   File "c:\builds\moz2_slave\rel-m-beta-w32_beta_u_t_1-0000\scripts\mozharness\base\script.py", line 1581, in run_action
21:09:45    ERROR -     method(action)
21:09:45    ERROR -   File "c:\builds\moz2_slave\rel-m-beta-w32_beta_u_t_1-0000\scripts\mozharness\mozilla\vcstools.py", line 47, in _pre_checkout
21:09:45    ERROR -     if not self.is_exe(file_path):
21:09:45    ERROR -   File "c:\builds\moz2_slave\rel-m-beta-w32_beta_u_t_1-0000\scripts\mozharness\base\script.py", line 739, in is_exe
21:09:45    ERROR -     return os.path.isfile(fpath) and os.access(fpath, os.X_OK)
21:09:45    ERROR -   File "c:\mozilla-build\python\lib\genericpath.py", line 29, in isfile
21:09:45    ERROR -     st = os.stat(path)
21:09:45    ERROR - TypeError: coercing to Unicode: need string or buffer, list found
21:09:45    FATAL - Aborting due to exception in pre-action listener.
21:09:45    FATAL - Running post_fatal callback...
21:09:45    FATAL - Exiting -1

Comment 1

[Armen [:armenzg]]

Attachment: Do not check if a list of parameters is an executable (Windows case)

In Windows we specify a list composed of the path to python and the path of the script to run:
http://hg.mozilla.org/build/mozharness/file/af321e004210/configs/generic_releng_config.py#l30

In such cases we should not try to check if the file is executable.

I'm also removing a leftover copy/pasted line.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8628808 [details] [diff] [review]
Do not check if a list of parameters is an executable (Windows case)

Review of attachment 8628808 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to defer to jlund on this one - I didn't even review the original code here.

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8628808 [details] [diff] [review]
Do not check if a list of parameters is an executable (Windows case)

Review of attachment 8628808 [details] [diff] [review]:
-----------------------------------------------------------------

if exe check is important to you, I guess you could do something like:

# untested
if isinstance(exe, list):
    # make sure each part of the list is an exe if the part is a abspath
    all(self._is_exe(section) if os.path.abspath(section) else True for section in exe))

though I guess that's fragile. Another option, and I suppose a more pythonic way to handle this, is to try/catch non existent or non executable paths in the command itself. Though that might be overkill.

tangent aside, I don't see anything damaging. shipping it wfm :)

Comment 4

[Armen [:armenzg]]

Thanks for the suggestion but I will leave it as-is.
This will be picked in next week's next beta.
https://hg.mozilla.org/build/mozharness/rev/3ea9c09c3228

Comment 5

[Jordan Lund (:jlund)]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production