1176360 - For Linux and Windows, we're using the same update verify configs for both 32-bit and 64-bit runs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Armen [:armenzg]]

http://hg.mozilla.org/build/mozharness/file/d086b196a37b/configs/update_tests/mozilla-beta.py#l3

Comment 1

[Armen [:armenzg]]

Attachment: [mozharness] Remove update tests configs, start using --firefox-ui-branch & --update-verify-config

I also removed this block because it is already specified in firefox_ui_tests [1]

> -        if 'checkout' in self.actions and (self.installer_url or self.installer_path):
> -            assert self.firefox_ui_branch, \
> -                'When you use --installer-url or --installer-path you need to specify ' \
> -                '--firefox-ui-branch. Valid values are mozilla-{central,aurora,beta,release,esr38}.'


[1] http://hg.mozilla.org/build/mozharness/file/af321e004210/mozharness/mozilla/testing/firefox_ui_tests.py

Comment 2

[Armen [:armenzg]]

Attachment: [buildbotcustom] do not use update_tests config, call --firefox-ui-branch & --update-verify-config

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 8628843 [details] [diff] [review]
[mozharness] Remove update tests configs, start using --firefox-ui-branch & --update-verify-config

Review of attachment 8628843 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozharness/mozilla/testing/firefox_ui_tests.py
@@ +58,5 @@
>                  self.firefox_ui_branch = self.config['firefox_ui_branch']
>              except:
> +                self.fatal(
> +                    'Please specify --firefox-ui-branch. Valid values '
> +                    'are mozilla-{central,aurora,beta,release,esr38}.')

This comment is bound to be wrong in the future. Must you specify branch names? Can you point at somewhere that will have a maintained list of branches instead? This patch seems fine otherwise.

Comment 4

[Armen [:armenzg]]

https://hg.mozilla.org/build/mozharness/rev/2a34e0fb3968
https://hg.mozilla.org/build/buildbotcustom/rev/53b1c2b6a694

Comment 5

[Jordan Lund (:jlund)]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/53b1c2b6a694

Comment 6

[Armen [:armenzg]]

python scripts/scripts/firefox_ui_updates.py --cfg generic_releng_config.py --firefox-ui-branch mozilla-beta --update-verify-config mozBeta-firefox-linux.cfg --tools-tag FIREFOX_40_0b2_RELEASE_RUNTIME --total-chunks 6 --this-chunk 1
python scripts/scripts/firefox_ui_updates.py --cfg generic_releng_config.py --firefox-ui-branch mozilla-beta --update-verify-config mozBeta-firefox-linux64.cfg --tools-tag FIREFOX_40_0b2_RELEASE_RUNTIME --total-chunks 6 --this-chunk 1