For Linux and Windows, we're using the same update verify configs for both 32-bit and 64-bit runs

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
9 months ago

People

(Reporter: armenzg, Assigned: armenzg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Blocks: 1148546
Created attachment 8628843 [details] [diff] [review]
[mozharness] Remove update tests configs, start using --firefox-ui-branch & --update-verify-config

I also removed this block because it is already specified in firefox_ui_tests [1]

> -        if 'checkout' in self.actions and (self.installer_url or self.installer_path):
> -            assert self.firefox_ui_branch, \
> -                'When you use --installer-url or --installer-path you need to specify ' \
> -                '--firefox-ui-branch. Valid values are mozilla-{central,aurora,beta,release,esr38}.'


[1] http://hg.mozilla.org/build/mozharness/file/af321e004210/mozharness/mozilla/testing/firefox_ui_tests.py
Assignee: nobody → armenzg
Status: NEW → ASSIGNED
Attachment #8628843 - Flags: review?(bhearsum)
Created attachment 8628844 [details] [diff] [review]
[buildbotcustom] do not use update_tests config, call --firefox-ui-branch & --update-verify-config
Attachment #8628844 - Flags: review?(bhearsum)
Comment on attachment 8628843 [details] [diff] [review]
[mozharness] Remove update tests configs, start using --firefox-ui-branch & --update-verify-config

Review of attachment 8628843 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozharness/mozilla/testing/firefox_ui_tests.py
@@ +58,5 @@
>                  self.firefox_ui_branch = self.config['firefox_ui_branch']
>              except:
> +                self.fatal(
> +                    'Please specify --firefox-ui-branch. Valid values '
> +                    'are mozilla-{central,aurora,beta,release,esr38}.')

This comment is bound to be wrong in the future. Must you specify branch names? Can you point at somewhere that will have a maintained list of branches instead? This patch seems fine otherwise.
Attachment #8628843 - Flags: review?(bhearsum) → review+
Attachment #8628844 - Flags: review?(bhearsum) → review+
python scripts/scripts/firefox_ui_updates.py --cfg generic_releng_config.py --firefox-ui-branch mozilla-beta --update-verify-config mozBeta-firefox-linux.cfg --tools-tag FIREFOX_40_0b2_RELEASE_RUNTIME --total-chunks 6 --this-chunk 1
python scripts/scripts/firefox_ui_updates.py --cfg generic_releng_config.py --firefox-ui-branch mozilla-beta --update-verify-config mozBeta-firefox-linux64.cfg --tools-tag FIREFOX_40_0b2_RELEASE_RUNTIME --total-chunks 6 --this-chunk 1
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.