1176402 - Make apz_test_native_event_utils.js and apz_test_utils.js more consistent

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

We've been adding stuff to these helper JS files as we write more APZ mochitests, and so they've been evolving a bit. We should make some of the code in them more consistent. For example:

- synthesizeNativeWheel takes aX and aY relative to the top-left of aElement's containing window, but synthesizeNativeTouch takes them relative to the top-left of aElement's bounding client rect.

- some of the code uses _getDOMWindowUtils from EventUtils.js and other code uses SpecialPowers.getDOMWindowUtils

Comment 1

[Botond Ballo [:botond]]

I need some of these changes for my new approach for bug 1175585. Stealing with permission.

Comment 2

[Botond Ballo [:botond]]

Attachment: MozReview Request: Bug 1176402 - Update a call to a function that has since been renamed. r=kats

Bug 1176402 - Update a call to a function that has since been renamed. r=kats

Comment 3

[Botond Ballo [:botond]]

Attachment: MozReview Request: Bug 1176402 - Have synthesizeNativeWheel() and synthesizeNativeMouseMove() accept coordinates relative to the element's bounding rect. r=kats

Bug 1176402 - Have synthesizeNativeWheel() and synthesizeNativeMouseMove() accept coordinates relative to the element's bounding rect. r=kats

Comment 4

[Botond Ballo [:botond]]

Attachment: MozReview Request: Bug 1176402 - Obtain the DOMWindowUtils object consistently in the APZ testing native event helpers. r=kats

Bug 1176402 - Obtain the DOMWindowUtils object consistently in the APZ testing native event helpers. r=kats

Comment 5

[Botond Ballo [:botond]]

The first patch isn't really related, it's just something I noticed while writing this one and didn't feel it was worth filing a separate bug for it.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9bf22409137

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8625725 [details]
MozReview Request: Bug 1176402 - Update a call to a function that has since been renamed. r=kats

https://reviewboard.mozilla.org/r/11905/#review10427

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8625726 [details]
MozReview Request: Bug 1176402 - Have synthesizeNativeWheel() and synthesizeNativeMouseMove() accept coordinates relative to the element's bounding rect. r=kats

https://reviewboard.mozilla.org/r/11907/#review10429

::: gfx/layers/apz/test/apz_test_native_event_utils.js:45
(Diff revision 1)
> +function coordinatesRelativeToWindow(aX, aY, aElement, aWindow) {

Compute the window from the element inside the function rather than passing in the window.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8625727 [details]
MozReview Request: Bug 1176402 - Obtain the DOMWindowUtils object consistently in the APZ testing native event helpers. r=kats

https://reviewboard.mozilla.org/r/11909/#review10431

Ship It!

Comment 9

[Botond Ballo [:botond]]

Comment on attachment 8625726 [details]
MozReview Request: Bug 1176402 - Have synthesizeNativeWheel() and synthesizeNativeMouseMove() accept coordinates relative to the element's bounding rect. r=kats

Bug 1176402 - Have synthesizeNativeWheel() and synthesizeNativeMouseMove() accept coordinates relative to the element's bounding rect. r=kats

Comment 10

[Botond Ballo [:botond]]

Comment on attachment 8625727 [details]
MozReview Request: Bug 1176402 - Obtain the DOMWindowUtils object consistently in the APZ testing native event helpers. r=kats

Bug 1176402 - Obtain the DOMWindowUtils object consistently in the APZ testing native event helpers. r=kats

Comment 11

[Botond Ballo [:botond]]

Addressed review comments, carrying r+.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=699264800943

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/42fa3442672c
https://hg.mozilla.org/integration/mozilla-inbound/rev/148e25920467
https://hg.mozilla.org/integration/mozilla-inbound/rev/b70171b78167

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/42fa3442672c
https://hg.mozilla.org/mozilla-central/rev/148e25920467
https://hg.mozilla.org/mozilla-central/rev/b70171b78167