1176408 - Release new versions of marionette-transport 0.5 and marionette-driver 0.9

Status: RESOLVED FIXED

Description

[Jonathan Griffin (:jgriffin)]

We should release new versions of marionette-transport and marionette-driver to pick up bug 1166033.

Comment 1

[Jonathan Griffin (:jgriffin)]

Created attachment 8624923 [details] [diff] [review]
Bump marionette-transport to 0.5 and marionette-driver to 0.9,

Comment 2

[Jonathan Griffin (:jgriffin)]

just to be safe: https://treeherder.mozilla.org/#/jobs?repo=try&revision=877432c20a36

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd73baf23939

Comment 4

[Henrik Skupin (:whimboo)]

Adding leave-open for uploading to PyPI.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dd73baf23939

Comment 6

[Henrik Skupin (:whimboo)]

I'm not allowed to upload those packages, so Jonathan will have to finish it off.

Comment 7

[Armen [:armenzg]]

Please NI if you need them uploaded to the internal Pypi (I can do that).

Comment 8

[Jonathan Griffin (:jgriffin)]

https://pypi.python.org/pypi/marionette-transport/0.5
https://pypi.python.org/pypi/marionette_driver/0.9

Comment 9

[Henrik Skupin (:whimboo)]

Armen can you please upload those two packages to the internal package mirror? Thanks.

Comment 10

[Martijn Wargers (zombie)]

This has broken our Gaia UI test Jenkins runs, see bug 1176882.

Comment 11

[Armen [:armenzg]]

Uploaded.

Comment 12

[Alberto Pastor [:albertopq]]

I think this patch broke Python tests in gaia-try:

error: Installed distribution marionette-transport 0.5 conflicts with requirement marionette-transport==0.4

Could you please take a look?

https://treeherder.mozilla.org/#/jobs?repo=gaia

Thanks!

Comment 13

[Henrik Skupin (:whimboo)]

This is actually handled in bug 1176882.

Comment 14

[Jonathan Griffin (:jgriffin)]

This might be a separate problem; where is setup_python.sh?  It probably needs to be adjusted.

Comment 15

[Jonathan Griffin (:jgriffin)]

No, setup_python.sh is fine; hopefully the fix in bug 1176882 will address this.

Comment 16

[Martijn Wargers (zombie)]

Bug 1176882 was fixed on 2015-06-26 04:34:58 PDT in mozilla-central. https://treeherder.mozilla.org/#/jobs?repo=gaia is still failing. Gip-master is also failing. Johnathan, I guess it can still take a while before the fix in bug 1176882 is merged into Gaia?

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central is not failing. I wonder why that's not failing.

Comment 17

[Jonathan Griffin (:jgriffin)]

m-c is not failing because it uses in-tree marionette packages.  Gaia-try uses PyPI, which is less ideal.

There is something in the dependency chain on gaia-try, which is still trying to pull in marionette-transport 0.4 and 0.5.  I think you may need to bump the deps in gaiatest.

Comment 18

[Martijn Wargers (zombie)]

I don't know how 'to bump the deps in gaiatest'. Dave Hunt, see comment 17, do you know how to do that?

Comment 19

[Henrik Skupin (:whimboo)]

Isn't it this file?

https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/requirements.txt

Comment 20

[Martijn Wargers (zombie)]

(In reply to Henrik Skupin (:whimboo) from comment #19)
> Isn't it this file?
> 
> https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/
> requirements.txt

I don't know, it is? And what do I need to bump there?

Comment 21

[Jonathan Griffin (:jgriffin)]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #20)
> (In reply to Henrik Skupin (:whimboo) from comment #19)
> > Isn't it this file?
> > 
> > https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/
> > requirements.txt
> 
> I don't know, it is? And what do I need to bump there?

Yes, it's that file.  And you'd need to change marionette_driver==0.7 to marionette_driver==0.9, and marionette_client==0.13 to marionette_client==0.16.  Of course, you should do a try run to make this this doesn't break anything!

Comment 22

[Alberto Pastor [:albertopq]]

(In reply to Jonathan Griffin (:jgriffin) from comment #21)
> (In reply to Martijn Wargers [:mwargers] (QA) from comment #20)
> > (In reply to Henrik Skupin (:whimboo) from comment #19)
> > > Isn't it this file?
> > > 
> > > https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/
> > > requirements.txt
> > 
> > I don't know, it is? And what do I need to bump there?
> 
> Yes, it's that file.  And you'd need to change marionette_driver==0.7 to
> marionette_driver==0.9, and marionette_client==0.13 to
> marionette_client==0.16.  Of course, you should do a try run to make this
> this doesn't break anything!

I tried doing this, and I got this error:

error: Installed distribution mozinfo 0.7 conflicts with requirement mozinfo>=0.8

Note that we heavily rely on gaia-try for landing gaia patches, so we should fix this as soon as possible. Let me know if I can help.

Thanks!

Comment 23

[Alberto Pastor [:albertopq]]

Actually, that error only happens locally. It seems to fix the issue in gaia-try

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=66badfdc7bb044efd4bf099e1bb8e962443c2c71

I'm going to land it and see how it goes.

Comment 24

[Alberto Pastor [:albertopq]]

Created attachment 8627144 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30737

Comment 25

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8627144 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30737

Gip is now back working[1]. Thanks for the patch, Alberto!

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=66badfdc7bb044efd4bf099e1bb8e962443c2c71

Comment 26

[Johan Lorenzo [:jlorenzo]]

Merged in gaia/master at: https://github.com/mozilla-b2g/gaia/commit/55beef540617694459bcb221ce8bcc92d395472d

Comment 27

[Firefox Product Integrity Bug Husbandry Bot (contact :emceeaich)]

Removing leave-open keyword from resolved bugs, per :sylvestre.