Release new versions of marionette-transport 0.5 and marionette-driver 0.9

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
7 months ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
We should release new versions of marionette-transport and marionette-driver to pick up bug 1166033.
(Assignee)

Comment 1

3 years ago
Created attachment 8624923 [details] [diff] [review]
Bump marionette-transport to 0.5 and marionette-driver to 0.9,
Attachment #8624923 - Flags: review?(dburns)
Attachment #8624923 - Flags: review?(dburns) → review+
Summary: Release new versions of marionette-transport and marionette-driver → Release new versions of marionette-transport 0.5 and marionette-driver 0.9
Adding leave-open for uploading to PyPI.
Keywords: leave-open
I'm not allowed to upload those packages, so Jonathan will have to finish it off.

Comment 7

3 years ago
Please NI if you need them uploaded to the internal Pypi (I can do that).
(Assignee)

Comment 8

3 years ago
https://pypi.python.org/pypi/marionette-transport/0.5
https://pypi.python.org/pypi/marionette_driver/0.9
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Armen can you please upload those two packages to the internal package mirror? Thanks.
Flags: needinfo?(armenzg)
Depends on: 1176882
This has broken our Gaia UI test Jenkins runs, see bug 1176882.

Comment 11

3 years ago
Uploaded.
Flags: needinfo?(armenzg)
I think this patch broke Python tests in gaia-try:

error: Installed distribution marionette-transport 0.5 conflicts with requirement marionette-transport==0.4

Could you please take a look?

https://treeherder.mozilla.org/#/jobs?repo=gaia

Thanks!
Flags: needinfo?(jgriffin)
This is actually handled in bug 1176882.
Flags: needinfo?(jgriffin)
(Assignee)

Comment 14

3 years ago
This might be a separate problem; where is setup_python.sh?  It probably needs to be adjusted.
Flags: needinfo?(apastor)
(Assignee)

Comment 15

3 years ago
No, setup_python.sh is fine; hopefully the fix in bug 1176882 will address this.
Flags: needinfo?(apastor)
Bug 1176882 was fixed on 2015-06-26 04:34:58 PDT in mozilla-central. https://treeherder.mozilla.org/#/jobs?repo=gaia is still failing. Gip-master is also failing. Johnathan, I guess it can still take a while before the fix in bug 1176882 is merged into Gaia?

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central is not failing. I wonder why that's not failing.
Flags: needinfo?(jgriffin)
(Assignee)

Comment 17

3 years ago
m-c is not failing because it uses in-tree marionette packages.  Gaia-try uses PyPI, which is less ideal.

There is something in the dependency chain on gaia-try, which is still trying to pull in marionette-transport 0.4 and 0.5.  I think you may need to bump the deps in gaiatest.
Flags: needinfo?(jgriffin)
I don't know how 'to bump the deps in gaiatest'. Dave Hunt, see comment 17, do you know how to do that?
Flags: needinfo?(dave.hunt)
(In reply to Henrik Skupin (:whimboo) from comment #19)
> Isn't it this file?
> 
> https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/
> requirements.txt

I don't know, it is? And what do I need to bump there?
(Assignee)

Comment 21

3 years ago
(In reply to Martijn Wargers [:mwargers] (QA) from comment #20)
> (In reply to Henrik Skupin (:whimboo) from comment #19)
> > Isn't it this file?
> > 
> > https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/
> > requirements.txt
> 
> I don't know, it is? And what do I need to bump there?

Yes, it's that file.  And you'd need to change marionette_driver==0.7 to marionette_driver==0.9, and marionette_client==0.13 to marionette_client==0.16.  Of course, you should do a try run to make this this doesn't break anything!
(In reply to Jonathan Griffin (:jgriffin) from comment #21)
> (In reply to Martijn Wargers [:mwargers] (QA) from comment #20)
> > (In reply to Henrik Skupin (:whimboo) from comment #19)
> > > Isn't it this file?
> > > 
> > > https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/
> > > requirements.txt
> > 
> > I don't know, it is? And what do I need to bump there?
> 
> Yes, it's that file.  And you'd need to change marionette_driver==0.7 to
> marionette_driver==0.9, and marionette_client==0.13 to
> marionette_client==0.16.  Of course, you should do a try run to make this
> this doesn't break anything!

I tried doing this, and I got this error:

error: Installed distribution mozinfo 0.7 conflicts with requirement mozinfo>=0.8

Note that we heavily rely on gaia-try for landing gaia patches, so we should fix this as soon as possible. Let me know if I can help.

Thanks!
Flags: needinfo?(jgriffin)
Actually, that error only happens locally. It seems to fix the issue in gaia-try

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=66badfdc7bb044efd4bf099e1bb8e962443c2c71

I'm going to land it and see how it goes.
Flags: needinfo?(jgriffin)
Attachment #8627144 - Flags: review?(jlorenzo)
Comment on attachment 8627144 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30737

Gip is now back working[1]. Thanks for the patch, Alberto!

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=66badfdc7bb044efd4bf099e1bb8e962443c2c71
Attachment #8627144 - Flags: review?(jlorenzo) → review+
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.