Closed Bug 1176415 Opened 10 years ago Closed 8 years ago

a=ssrc lines on m=application lines

Categories

(Core :: WebRTC: Signaling, defect, P2)

Product:
Core
Component:
WebRTC: Signaling
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox41 --- affected
firefox55 --- fixed
Blocking Flags:
backlog webrtc/webaudio+

People

(Reporter: mt, Assigned: drno)

Details

Attachments

(2 files)

Bug 1176415: stop adding ssrc's to data channel m-sections.
59 bytes, text/x-review-board-request
bwc
: review+
Details
Bug 1176415: verify absence of SSRC's in data channel m-sections.
59 bytes, text/x-review-board-request
bwc
: review+
Details
Probably not a good idea. Is this fallout from bug 1160280?
backlog: --- → webRTC+
Rank: 15
Priority: -- → P1
Possibly, I'll look into it.
Assignee: nobody → docfaraday
Paul -- Can you take a look at this? Byron has several P1 bugs on his plate, and I'm looking to offload him some.
Assignee: docfaraday → pkerr
I will take a look.
Could you expend on your objection? Do you hold the addition of ssrc to recvonly m= sections as specified in bug 1160280 to also be a problem?
Flags: needinfo?(martin.thomson)
Status: NEW → ASSIGNED
(In reply to Paul Kerr [:pkerr] from comment #4) > Could you expend on your objection? Do you hold the addition of ssrc to > recvonly m= sections as specified in bug 1160280 to also be a problem? Since m=application lines aren't for RTP/RTCP, having an ssrc doesn't make any sense, recvonly or not. Having recvonly ssrcs is fine, since that is what it looks like the standards will settle on.
Wot :bwc sed.
Flags: needinfo?(martin.thomson)
Paul - can you look at this after the 43 update lands, or if you're blocked waiting on others? Thanks
Rank: 15 → 22
Priority: P1 → P2
Assignee: paulrkerr → drno
Comment on attachment 8873306 [details] Bug 1176415: stop adding ssrc's to data channel m-sections. https://reviewboard.mozilla.org/r/144756/#review148794 Can we get a test-case?
Attachment #8873306 - Flags: review?(docfaraday) → review-
Comment on attachment 8873549 [details] Bug 1176415: verify absence of SSRC's in data channel m-sections. https://reviewboard.mozilla.org/r/144932/#review148900 Fair enough.
Attachment #8873549 - Flags: review?(docfaraday) → review+
Comment on attachment 8873306 [details] Bug 1176415: stop adding ssrc's to data channel m-sections. https://reviewboard.mozilla.org/r/144756/#review148902
Attachment #8873306 - Flags: review?(docfaraday) → review+
Pushed by drno@ohlmeier.org: https://hg.mozilla.org/integration/autoland/rev/12fa2783b2cc stop adding ssrc's to data channel m-sections. r=bwc https://hg.mozilla.org/integration/autoland/rev/4ec75a4481fc verify absence of SSRC's in data channel m-sections. r=bwc
https://hg.mozilla.org/mozilla-central/rev/12fa2783b2cc https://hg.mozilla.org/mozilla-central/rev/4ec75a4481fc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: