1176698 - Use fallible allocator for attribute values in the HTML parser

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: htmlparser repo patch

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: m-c patch

Comment 3

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c22005c9be97

Comment 4

[Henri Sivonen (:hsivonen)]

This is some ugly code, but AFAICT, this is the most practical way to signal error out of the nsHtml5Portability calls. :-(

Comment 5

[Henri Sivonen (:hsivonen)]

Comment on attachment 8625290 [details] [diff] [review]
m-c patch

See bug 1029671 comment 36 for the big picture of the whole queue and about landing.

Comment 6

[William Chen [:wchen]]

Comment on attachment 8625289 [details] [diff] [review]
htmlparser repo patch

Review of attachment 8625289 [details] [diff] [review]:
-----------------------------------------------------------------

::: src/nu/validator/htmlparser/impl/MetaScanner.java
@@ +164,5 @@
>      
> +    // CPPONLY: private TreeBuilder treeBuilder;
> +    
> +    public MetaScanner(
> +        // CPPONLY: TreeBuilder tb        

trailing whitespace

::: src/nu/validator/htmlparser/impl/TreeBuilder.java
@@ +3184,5 @@
>       * @throws SAXException
>       * @throws StopSniffingException
>       */
> +    public static String extractCharsetFromContent(String attributeValue
> +        // CPPONLY: , TreeBuilder tb        

trailing whitespace

Comment 7

[Henri Sivonen (:hsivonen)]

Attachment: htmlparser repo patch, review comments addressed

Comment 8

[Henri Sivonen (:hsivonen)]

Attachment: m-c patch, review comments addressed

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/470bee720c97

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/470bee720c97