Closed
Bug 1176698
Opened 8 years ago
Closed 8 years ago
Use fallible allocator for attribute values in the HTML parser
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(2 files, 2 obsolete files)
10.50 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
29.70 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c22005c9be97
Assignee | ||
Comment 4•8 years ago
|
||
This is some ugly code, but AFAICT, this is the most practical way to signal error out of the nsHtml5Portability calls. :-(
Assignee | ||
Updated•8 years ago
|
Attachment #8625289 -
Flags: review?(wchen)
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8625290 [details] [diff] [review] m-c patch See bug 1029671 comment 36 for the big picture of the whole queue and about landing.
Attachment #8625290 -
Flags: review?(wchen)
Updated•8 years ago
|
Attachment #8625290 -
Flags: review?(wchen) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8625289 [details] [diff] [review] htmlparser repo patch Review of attachment 8625289 [details] [diff] [review]: ----------------------------------------------------------------- ::: src/nu/validator/htmlparser/impl/MetaScanner.java @@ +164,5 @@ > > + // CPPONLY: private TreeBuilder treeBuilder; > + > + public MetaScanner( > + // CPPONLY: TreeBuilder tb trailing whitespace ::: src/nu/validator/htmlparser/impl/TreeBuilder.java @@ +3184,5 @@ > * @throws SAXException > * @throws StopSniffingException > */ > + public static String extractCharsetFromContent(String attributeValue > + // CPPONLY: , TreeBuilder tb trailing whitespace
Attachment #8625289 -
Flags: review?(wchen) → review+
Assignee | ||
Comment 7•8 years ago
|
||
Attachment #8625289 -
Attachment is obsolete: true
Attachment #8644273 -
Flags: review+
Assignee | ||
Comment 8•8 years ago
|
||
Attachment #8625290 -
Attachment is obsolete: true
Attachment #8644274 -
Flags: review+
Comment 10•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/470bee720c97
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•