1176699 - Hitting previously cancelled download with --persist crashes mozregression

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Elbart]

When doing a regression with --persist, and cancelling (ctrl-x/ctrl-c) during a download, the incomplete download remains in the folder.
AFAIK the download was previously named with .part at the end, but now the file has the original name.

When you do another regression and hit the build whose download was cancelled previously, mozregression exits with an error:

 4:52.13 LOG: MainThread Bisector INFO Using local file: k:/fx\1433753443--mozil
la-inbound--firefox-41.0a1.en-US.win32.zip
 4:52.13 LOG: MainThread Test Runner INFO Testing inbound build with timestamp 1
433753443, revision ab947127
Traceback (most recent call last):
  File "c:\mozilla-build\python\Scripts\mozregression-script.py", line 8, in <mo
dule>
    load_entry_point('mozregression==0.36', 'console_scripts', 'mozregression')(
)
  File "build\bdist.win32\egg\mozregression\main.py", line 368, in cli
  File "build\bdist.win32\egg\mozregression\main.py", line 271, in bisect_nightl
ies
  File "build\bdist.win32\egg\mozregression\bisector.py", line 510, in bisect_ni
ghtlies
  File "build\bdist.win32\egg\mozregression\bisector.py", line 539, in bisect_in
bound
  File "build\bdist.win32\egg\mozregression\main.py", line 205, in do_bisect
  File "build\bdist.win32\egg\mozregression\bisector.py", line 496, in do_bisect

  File "build\bdist.win32\egg\mozregression\bisector.py", line 454, in bisect
  File "build\bdist.win32\egg\mozregression\bisector.py", line 475, in _bisect
  File "build\bdist.win32\egg\mozregression\bisector.py", line 372, in evaluate
  File "build\bdist.win32\egg\mozregression\test_runner.py", line 110, in evalua
te
  File "build\bdist.win32\egg\mozregression\test_runner.py", line 44, in create_
launcher
  File "build\bdist.win32\egg\mozregression\launchers.py", line 139, in create_l
auncher
  File "build\bdist.win32\egg\mozregression\launchers.py", line 45, in __init__
  File "build\bdist.win32\egg\mozregression\launchers.py", line 102, in _install

  File "c:\mozilla-build\python\lib\site-packages\mozinstall\mozinstall.py", lin
e 106, in install
    raise InvalidSource(src + ' is not valid installer file.')
mozinstall.mozinstall.InvalidSource: k:\fx\1433753443--mozilla-inbound--firefox-
41.0a1.en-US.win32.zip is not valid installer file.

Comment 1

[Elbart]

Correction: I wasn't cancelling using Ctrl-C but by closing the MING32-window of MozillaBuild while the download was running.

Comment 2

[Julien Pagès (:parkouss)]

Yay, thanks Elbart for reporting it!

Comment 3

[Julien Pagès (:parkouss)]

Attachment: create temp file while downloading

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8625542 [details] [review]
create temp file while downloading

Looks good except one small issue.

Comment 5

[Julien Pagès (:parkouss)]

Yep, fixed! Thanks Will.

Merged with https://github.com/mozilla/mozregression/commit/c32bd8f3910da61db78f1383bc97b8fca526e9a9.