1176709 - [Build 22-24] Removing history item results in crash

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Plewako [:stef]]

The browser crashes on iPhone 5s and iOS 8 when I go to history pane and try to remove an item.

Comment 1

[Alex Davis [:adavis]]

I confirm. It does the same on iPhone 6, iOS 8.

Comment 2

[Richard Newman [:rnewman]]

Can't repro in current trunk. Anyone else?

Comment 3

[Stephan Leroux [:sleroux]]

Not able to reproduce this on the 6 simulator or my iPhone 6 device.

Comment 4

[Alex Davis [:adavis]]

I'm on build 21, not 22 so perhaps it has been resolved. I do not however have access to 22 yet so I can't confirm if this is true.

Comment 6

[Emily Toop (:fluffyemily)]

This has been resolved in current master

Comment 7

[Stefan Plewako [:stef]]

I can still reproduce this with TestFlight build 24.

Comment 8

[Aaron Train [:aaronmt]]

(In reply to Stefan Plewako [:stef] from comment #7)
> I can still reproduce this with TestFlight build 24.

Is this with a reinstall too? Sounds like a broken state

Comment 9

[Stefan Plewako [:stef]]

(In reply to Aaron Train [:aaronmt] from comment #8)
> Is this with a reinstall too? Sounds like a broken state

The same thing if I force quit, remove and install it again. One strange thing is that I see my fxa logged in right after that in settings (not in on-boarding tour which displays as expected).

Comment 10

[Richard Newman [:rnewman]]

Stefan, could you pull a crash log off your device?

http://osxdaily.com/2012/08/07/get-crash-reports-logs-from-iphone-ipad/

Comment 11

[Alex Davis [:adavis]]

(In reply to Stefan Plewako [:stef] from comment #7)
> I can still reproduce this with TestFlight build 24.

I can also reproduce it in build 24. I only upgraded though. I did not do a full re-install.

I'll try to pull a crash log too when I have a few mins.

Comment 12

[Stefan Plewako [:stef]]

Attachment: Client_2015-07-13-223539_omron6.ips.beta

Comment 13

[Richard Newman [:rnewman]]

st3fan, can you symbolicate that? Needs the dSYM from the TestFlight build.

Comment 14

[Wesley Johnston (:wesj)]

I just landed some changes in bug 1161630 to fix a crash I saw here (related to new rows being added to the bottom of the list).

Comment 15

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I assume this is the one crash that you can see in the Organizer -> Crashes now.

Comment 16

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

We need a better STR for this bug. I am unable to repro this.

Comment 17

[Wesley Johnston (:wesj)]

The one I saw would only happen if you had over 100 items in your history.

Comment 18

[Alex Davis [:adavis]]

Attachment: Client_2015-07-14-133720_MyPhone.crash

Here is my phone's crash report. Hope this helps.

Comment 19

[Alex Davis [:adavis]]

If the crash report isn't useful, I am in the Mountain View office and don't mind walking over to someone's desk to reproduce the bug in person.

Comment 20

[Stefan Plewako [:stef]]

(In reply to Wesley Johnston (:wesj) from comment #17)
> The one I saw would only happen if you had over 100 items in your history.

Just tested this and it seems to be the thing.

After logging out of fxa, force quiting app, removing from disk, freshly installing from TestFlight (iPhone 5s, iOS 8), I don't get crashes until opening over ~100 pages.

Comment 21

[Emily Toop (:fluffyemily)]

Attachment: Pull request

This code is more simplistic than the previous version, but it definitely covers all eventualities which the other did not.

Comment 22

[Stephan Leroux [:sleroux]]

Comment on attachment 8634757 [details] [review]
Pull request

Looks good!