1176759 - Ship-it returns 500

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Rail Aliiev [:rail]]

https://ship-it.mozilla.org/releases/Fennec-39.0b8-build1 for example.

Comment 1

[Rail Aliiev [:rail]]

Looks like related to https://github.com/mozilla/ship-it/pull/23:

Traceback (most recent call last):
  File "/data/www/ship-it.mozilla.org/release-kickoff/vendor/lib/python/flask/app.py", line 1687, in wsgi_app
    response = self.full_dispatch_request()
  File "/data/www/ship-it.mozilla.org/release-kickoff/vendor/lib/python/flask/app.py", line 1360, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/lib64/python2.6/site-packages/newrelic-2.44.0.36/newrelic/hooks/framework_flask.py", line 98, in _nr_wrapper_Flask_handle_exception_
    return wrapped(*args, **kwargs)
  File "/data/www/ship-it.mozilla.org/release-kickoff/vendor/lib/python/flask/app.py", line 1358, in full_dispatch_request
    rv = self.dispatch_request()
  File "/data/www/ship-it.mozilla.org/release-kickoff/vendor/lib/python/flask/app.py", line 1344, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/lib64/python2.6/site-packages/newrelic-2.44.0.36/newrelic/hooks/framework_flask.py", line 40, in _nr_wrapper_handler_
    return wrapped(*args, **kwargs)
  File "/data/www/ship-it.mozilla.org/release-kickoff/vendor/lib/python/flask/views.py", line 83, in view
    return self.dispatch_request(*args, **kwargs)
  File "/data/www/ship-it.mozilla.org/release-kickoff/vendor/lib/python/flask/views.py", line 150, in dispatch_request
    return meth(*args, **kwargs)
  File "/data/www/ship-it.mozilla.org/release-kickoff/kickoff/views/releases.py", line 58, in get
    return jsonify(table.query.filter_by(name=releaseName).first().toDict())
  File "/data/www/ship-it.mozilla.org/release-kickoff/kickoff/model.py", line 81, in toDict
    me[c.name] = getattr(self, c.name)
  File "/usr/lib64/python2.6/site-packages/sqlalchemy/ext/hybrid.py", line 465, in __get__
    return self.fget(instance)
  File "/data/www/ship-it.mozilla.org/release-kickoff/kickoff/model.py", line 51, in shippedAt
    return pytz.utc.localize(self._shippedAt).isoformat()
  File "/usr/lib/python2.6/site-packages/pytz/__init__.py", line 196, in localize
    if dt.tzinfo is not None:
AttributeError: 'NoneType' object has no attribute 'tzinfo'

Comment 2

[Rail Aliiev [:rail]]

FTR,
mysql> select count(*) from firefox_release where shippedAt is NULL;
+----------+
| count(*) |
+----------+
|       72 |
+----------+
1 row in set (0.00 sec)

mysql> select count(*) from firefox_release;
+----------+
| count(*) |
+----------+
|      640 |
+----------+
1 row in set (0.00 sec)

Comment 3

[Rail Aliiev [:rail]]

Attachment: Do not operate on None

Comment 4

[Rail Aliiev [:rail]]

Another option would be reverting https://github.com/mozilla/ship-it/pull/23. I'm not sure what should we also do to revert the db changes (if needed).

Comment 5

[Rail Aliiev [:rail]]

(In reply to Rail Aliiev [:rail] from comment #4)
> Another option would be reverting
> https://github.com/mozilla/ship-it/pull/23. I'm not sure what should we also
> do to revert the db changes (if needed).

I would prefer this option, because the change made in this PR is big enough to make us patch it multiple times.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Sure, the priority goes to the release. 
I can also use the work week to work with Ben and you on this.

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8625352 [details] [review]
Do not operate on None

https://github.com/mozilla/ship-it/pull/26 reverted

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Rail, Ben, I would like to try to deploy https://github.com/mozilla/ship-it/pull/23 (aka bug 1083718).
However, we will have this bug again. Does Rail's patch in comment #7 have a chance to work? 
Or do we have now a staging env to test that?

Of course, I won't ask for a deployment of that before 40 is released.

thanks

Comment 9

[Rail Aliiev [:rail]]

It's been a while, but IIRC the patch should fix the issue.