Closed
Bug 1176981
Opened 9 years ago
Closed 9 years ago
kill pref'd off, never finished prototype tracing debugger
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Firefox 42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(3 files)
72.01 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
74.70 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
1.23 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
Using the tracelogger would mean re-writing the actor and server side.
Having the UI be performant would mean re-writing it.
We have vcs if we ever want to look again.
Let's remove this stuff from the tree.
Comment 1•9 years ago
|
||
+1, or as dcamp would say 'with fire'.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → nfitzgerald
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8630085 -
Flags: review?(past)
Assignee | ||
Updated•9 years ago
|
Attachment #8630086 -
Flags: review?(past)
Assignee | ||
Updated•9 years ago
|
Attachment #8630087 -
Flags: review?(past)
Assignee | ||
Comment 5•9 years ago
|
||
Panos, review ping.
Comment 6•9 years ago
|
||
I can steal this from panos if he's too busy.
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Victor Porof [:vporof][:vp] from comment #6)
> I can steal this from panos if he's too busy.
Be my guest :)
Comment 8•9 years ago
|
||
Comment on attachment 8630085 [details] [diff] [review]
Part 0: Remove the tracing debugger UI
Review of attachment 8630085 [details] [diff] [review]:
-----------------------------------------------------------------
Straightforward removal. r+ assuming all tests still pass.
Attachment #8630085 -
Flags: review?(past) → review+
Comment 9•9 years ago
|
||
Comment on attachment 8630086 [details] [diff] [review]
Part 1: Remove the tracing debugger actor from the server
Review of attachment 8630086 [details] [diff] [review]:
-----------------------------------------------------------------
Ditto
Attachment #8630086 -
Flags: review?(past) → review+
Updated•9 years ago
|
Attachment #8630087 -
Flags: review?(past) → review+
Comment 10•9 years ago
|
||
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1e2cbe60bbbd
https://hg.mozilla.org/mozilla-central/rev/365f3d257b80
https://hg.mozilla.org/mozilla-central/rev/0023b4a6e33c
Rev 0023b4a6e33c was an empty commit, FWIW.
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment 12•9 years ago
|
||
Comment 13•9 years ago
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•