Closed Bug 1177014 Opened 5 years ago Closed 4 months ago

Line offsets incorrect for block followed by list

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: Jamie, Assigned: morgan)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Str:
1. Open this URL: data:text/html,<div>block</div><ul><li>li</li></ul>
2. Retrieve the accessible for the document.
3. Retrieve the line offsets at offset 0.
Expected: (0, 1)
Actual: (0, 2)
4. Retrieve the line offsets at offset 1.
Result (correct): (1, 2)

Impact: This causes ATs to report that the list is part of the line with the block when it isn't.
here's an example how a test may be constructed: https://dxr.mozilla.org/mozilla-central/source/accessible/tests/mochitest/text/test_lineboundary.html#33,34-36

as long as we have a test case, the next step is to figure out where's out expectations are broken, I suppose that a start point for the debugging could be at HyperTextAccessible::FindOffset.
Attached patch Test case patch.Splinter Review

Here's a patch which adds a (currently failing) test case for this bug.

Assignee: nobody → jteh
Assignee: jteh → nobody
Assignee: nobody → mreschenberg
Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7aa2279f941c
Modify TransformOffset to correctly report bullet offsets, despite incorrect return from PeekOffset. r=Jamie
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Regressions: 1584465
You need to log in before you can comment on or make changes to this bug.