1177014 - Line offsets incorrect for block followed by list

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

Str:
1. Open this URL: data:text/html,<div>block</div><ul><li>li</li></ul>
2. Retrieve the accessible for the document.
3. Retrieve the line offsets at offset 0.
Expected: (0, 1)
Actual: (0, 2)
4. Retrieve the line offsets at offset 1.
Result (correct): (1, 2)

Impact: This causes ATs to report that the list is part of the line with the block when it isn't.

Comment 1

[alexander :surkov (:asurkov)]

here's an example how a test may be constructed: https://dxr.mozilla.org/mozilla-central/source/accessible/tests/mochitest/text/test_lineboundary.html#33,34-36

as long as we have a test case, the next step is to figure out where's out expectations are broken, I suppose that a start point for the debugging could be at HyperTextAccessible::FindOffset.

Comment 2

[James Teh [:Jamie]]

Attachment: Test case patch.

Here's a patch which adds a (currently failing) test case for this bug.

Comment 3

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1177014: Modify TransformOffset to correctly report bullet offsets, despite incorrect return from PeekOffset.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7aa2279f941c
Modify TransformOffset to correctly report bullet offsets, despite incorrect return from PeekOffset. r=Jamie

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7aa2279f941c