1177171 - Popup sizing is often incorrect on GTK3 with HiDPI

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Andrew Comminos [:acomminos]]

Steps to reproduce:
- Open two right click context menus whose content dictates they should be sized differently using a GDK scale factor >= 2
- Observe odd spacing or sizing in content

Comment 1

[Andrew Comminos [:acomminos]]

This appears to be the GTK3 equivalent of bug 892994. Whipping up a simple patch that corrects this behaviour using the existing OS X infrastructure.

Comment 2

[Andrew Comminos [:acomminos]]

Attachment: Round widget coordinates on GTK3.

This patch ensures that the coordinates used for popup widgets are divisible by GDK's scale factor, maintaining consistency between the window and our bounds. Thanks!

Comment 3

[Andrew Comminos [:acomminos]]

Try push (GTK3): https://treeherder.mozilla.org/#/jobs?repo=try&revision=24bede8ad191

Comment 4

[Carsten Book [:Tomcat]]

Hey Andrew this try run show a lot of reftest failures are those related to your change ?

Comment 5

[Andrew Comminos [:acomminos]]

Nope, these occur on the main GTK3 branch as well:

https://treeherder.mozilla.org/#/jobs?repo=elm

As the patch only affects GTK3 I didn't see much point in doing a GTK2 try push.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba5ae82b4733

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ba5ae82b4733