Closed Bug 117722 Opened 24 years ago Closed 23 years ago

DOM Inspector access key conflicts with the Import utility

Categories

(Other Applications :: DOM Inspector, defect)

x86
Windows 95
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED WONTFIX
Future

People

(Reporter: neil, Assigned: neil)

Details

(Keywords: polish)

Attachments

(1 file, 2 obsolete files)

Tasks/Tooks/Import Utility uses I as its access key so DOM Inspector should use D.
Attached patch Proposed patch (obsolete) — Splinter Review
Keywords: patch, polish, review, ui
Comment on attachment 63244 [details] [diff] [review] Proposed patch r=bzbarsky
Attachment #63244 - Flags: review+
Personally disagree with the accesskey chosen. D should be for debugger which currently has no accesskey. People will be more apt to call them Inspector and Debugger. Therefore the mnemonics should be chosen appropriately. Either I or N should be the inspector accesskey and the D should go to Debugger. Also, why is Import Utility there? Can we get rid of it? Or change it's acceskey to M or U so that Inspector can have I?
Attachment #63255 - Flags: review+
jglick: we're going to remove the import utility. users who want to import stuff can use file>import in mail.
I have mixed feelings about removing the menu item. On the one hand, each component that needs Import/Export has the menu item in its File menu already (Address Book, Mail, Manage Bookmarks). On the other hand, do we want each component to have separate Import/Export items? Or would a global type Import tool/wizard, in which users could go to one place to Import/Export Address Books, Mail or Bookmarks make sense? cc'ing Marlon and Lori for their opinion.
jglick: if a tree is removed from the forest and no one complains was it worth keeping? alecf: would you sr= this? at the very least we'd get feedback from the 0.9.8 release.
why remove it? Why not just fix the access key?
because import exists in file>import. There's no reason to keep an extra copy of it at a deeper level.
I'm not saying we shouldn't remove it. That may very well be the right thing to do. But I think we need to make sure a broader set of folks are aware of this before you remove a menu item. Yes the menu item appears in several places. But there are two ways to solve this. 1) Leave Import/Export in the File menu of each applicable component and removed the more hidden global menu item. 2) Make the Global Import/Export menu item more obvious and remove all the individual component menu items.
Comment on attachment 63254 [details] [diff] [review] Patch to remove Tasks/Tools/Import at timeless and caillon's request Actually the global item is in the wrong overlay so it needs removing anyway.
Attachment #63254 - Attachment is obsolete: true
-> neil
Assignee: hewitt → neil
Target Milestone: --- → Future
Fixed by the Tools menu reorganization.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
Product: Core → Other Applications
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: