1177260 - Non-match search should show feedback to user

Status: VERIFIED FIXED

(DevTools :: Framework, enhancement)

Description

[Daniel Davis]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150511103818

Steps to reproduce:

In the developer tools "Debugger" panel, search for something that produces no results (e.g. asdfasdf).


Actual results:

Nothing.


Expected results:

A "not found" message should be shown to the user. At present, it looks as though search is not working.

Comment 1

[Brindusa Tot, DTE]

Verified this on latest Nightly build 46.0a1, Build ID 20151215030221. Appears that the search on Debugger tool, was design to display results on the fly, so if no results should be displayed at search, then nothing happens.

In my opinion this works as designed, but perhaps there's someone with extensive knowledge on this area that might be able to provide more info related to this.

Comment 2

[Sebastian Zartner [:sebo]]

Additionally to the textual indication that there were no matches I could imagine the search box to turn red in that case.

I moved it to the 'Developer Tools: Framework' component, as this affects the search fields of all panels.

Sebastian

Comment 3

[Sebastian Zartner [:sebo]]

In the new debugger frontend (currently available in Firefox Nightly and Developer Edition) this is already handled by showing a sad smiley, making the text color red and saying 'no results' at the end of the search field.
So, this only depends on when the new UI gets shipped.

Patrick, should this bug be closed then?

Sebastian

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Sebastian Zartner [:sebo] from comment #3)
> In the new debugger frontend (currently available in Firefox Nightly and
> Developer Edition) this is already handled by showing a sad smiley, making
> the text color red and saying 'no results' at the end of the search field.
> So, this only depends on when the new UI gets shipped.
> 
> Patrick, should this bug be closed then?

I suspect yes, but forwarding needinfo to Jason

Comment 5

[Deac Alin]

Tested on Nightly 57.0a1 Build ID 20170919100405
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0) Gecko/20100101 Firefox/57.0

Now, when searching for something that produces no results In the developer tools "Debugger" panel, a "No results found" message is properly displayed. Marking this as Verified fixed. Thank you