Last Comment Bug 1177454 - Reviewer detection sometimes fails due to user being logged out
: Reviewer detection sometimes fails due to user being logged out
Status: RESOLVED FIXED
:
Product: MozReview
Classification: Other
Component: General (show other bugs)
: unspecified
: Unspecified Unspecified
-- normal
: ---
Assigned To: Mark Côté [:mcote]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-06-25 11:48 PDT by Mark Côté [:mcote]
Modified: 2016-02-21 20:31 PST (History)
4 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

MozReview Requests
Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:
Show discarded requests

Attachments
MozReview Request: mozreview: Always record cookies in session when logging in (bug 1177454). r?dminor (40 bytes, text/x-review-board-request)
2015-06-25 15:00 PDT, Mark Côté [:mcote]
dminor: review+
Details | Review

Description User image Mark Côté [:mcote] 2015-06-25 11:48:55 PDT
The main problem with reviewer detection appears to be this:

Bugzilla error: Logged-out users cannot use the "match" argument to this function to access any user information. (HTTP 500, API Error 226)

I have a feeling it's related to cookie auth.

There's another reviewer-detection problem in bug 1169724, but it's a separate problem, with Bugzilla itself.
Comment 1 User image Ted Mielczarek [:ted.mielczarek] 2015-06-25 11:53:03 PDT
Mark and I were talking about this on the walk to breakfast this morning. My ~/.hgrc just has my bugzilla username, and fetches my bugzilla cookie out of my Firefox profile for auth. I've never had reviewer matching work.
Comment 2 User image Mark Côté [:mcote] 2015-06-25 15:00:00 PDT
Created attachment 8626335 [details]
MozReview Request: mozreview: Always record cookies in session when logging in (bug 1177454). r?dminor

mozreview: Always record cookies in session when logging in (bug 1177454). r?dminor

The Bugzilla authentication layer was not setting the user cookie variables,
which are saved to the session, when the login was performed with cookies.
This was probably left over from an early attempt to use Bugzilla's cookies
directly when authenticated with the UI.  Now we only use cookies with
API authentication, so we need to percolate them up to the middleware to save
in the session.
Comment 3 User image Dan Minor [:dminor] 2015-06-25 15:01:17 PDT
Comment on attachment 8626335 [details]
MozReview Request: mozreview: Always record cookies in session when logging in (bug 1177454). r?dminor

https://reviewboard.mozilla.org/r/12065/#review10481

Ship It!

Note You need to log in before you can comment on or make changes to this bug.