1177454 - Reviewer detection sometimes fails due to user being logged out

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Mark Côté [:mcote]]

The main problem with reviewer detection appears to be this:

Bugzilla error: Logged-out users cannot use the "match" argument to this function to access any user information. (HTTP 500, API Error 226)

I have a feeling it's related to cookie auth.

There's another reviewer-detection problem in bug 1169724, but it's a separate problem, with Bugzilla itself.

Comment 1

[(not currently active) Ted Mielczarek]

Mark and I were talking about this on the walk to breakfast this morning. My ~/.hgrc just has my bugzilla username, and fetches my bugzilla cookie out of my Firefox profile for auth. I've never had reviewer matching work.

Comment 2

[Mark Côté [:mcote]]

Attachment: MozReview Request: mozreview: Always record cookies in session when logging in (bug 1177454). r?dminor

mozreview: Always record cookies in session when logging in (bug 1177454). r?dminor

The Bugzilla authentication layer was not setting the user cookie variables,
which are saved to the session, when the login was performed with cookies.
This was probably left over from an early attempt to use Bugzilla's cookies
directly when authenticated with the UI.  Now we only use cookies with
API authentication, so we need to percolate them up to the middleware to save
in the session.

Comment 3

[Dan Minor [:dminor]]

Comment on attachment 8626335 [details]
MozReview Request: mozreview: Always record cookies in session when logging in (bug 1177454). r?dminor

https://reviewboard.mozilla.org/r/12065/#review10481

Ship It!

Comment 4

[Mark Côté [:mcote]]

http://hg.mozilla.org/hgcustom/version-control-tools/rev/4d6865755492