Closed
Bug 1177454
Opened 9 years ago
Closed 9 years ago
Reviewer detection sometimes fails due to user being logged out
Categories
(MozReview Graveyard :: General, defect)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcote, Unassigned)
Details
Attachments
(1 file)
The main problem with reviewer detection appears to be this: Bugzilla error: Logged-out users cannot use the "match" argument to this function to access any user information. (HTTP 500, API Error 226) I have a feeling it's related to cookie auth. There's another reviewer-detection problem in bug 1169724, but it's a separate problem, with Bugzilla itself.
Comment 1•9 years ago
|
||
Mark and I were talking about this on the walk to breakfast this morning. My ~/.hgrc just has my bugzilla username, and fetches my bugzilla cookie out of my Firefox profile for auth. I've never had reviewer matching work.
Assignee | ||
Comment 2•9 years ago
|
||
mozreview: Always record cookies in session when logging in (bug 1177454). r?dminor The Bugzilla authentication layer was not setting the user cookie variables, which are saved to the session, when the login was performed with cookies. This was probably left over from an early attempt to use Bugzilla's cookies directly when authenticated with the UI. Now we only use cookies with API authentication, so we need to percolate them up to the middleware to save in the session.
Attachment #8626335 -
Flags: review?(dminor)
Comment 3•9 years ago
|
||
Comment on attachment 8626335 [details] MozReview Request: mozreview: Always record cookies in session when logging in (bug 1177454). r?dminor https://reviewboard.mozilla.org/r/12065/#review10481 Ship It!
Attachment #8626335 -
Flags: review?(dminor) → review+
Assignee | ||
Comment 4•9 years ago
|
||
http://hg.mozilla.org/hgcustom/version-control-tools/rev/4d6865755492
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•