1177639 - "Copy" context menu is missing on bookmarks

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

Steps to reproduce:
1. Enable Bookmarks Toolbar
2. Right click on a bookmarks on the toolbar
   --- "Copy" context menu is available as expected
3. Right click on a bookmarks on the toolbar and Choose "Paste"
   --- The bookmark item is pasted as expected
4. Right click again on a bookmarks in menubar/toolbar/widget ui

Actual Results:
"Copy" context menu is missing. No longer available.

Expected Results:
"Copy" context menu should be available.

Comment 1

[Alice0775 White]

Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=54cb0b2e118b&tochange=5d467596b176

REGRESSED BY: 5d467596b176	Gijs Kruitbosch — Bug 1006989 - hide and disable cut/copy/delete/properties when opening bookmarks context menu with no selection, r=mano

Comment 2

[Alice0775 White]

corrected
> 3. Right click on a bookmarks on the toolbar and Choose "Paste"
3. Right click on bookmarks toolbar empty area and Choose "Paste"

Comment 3

[Marco Bonardo [:mak]]

it doesn't make sense to track this when we already released 6 versions with the bug.

Comment 4

[:Gijs (he/him)]

Attachment: Patch

Simplified STR: right click an empty area of the bookmarks toolbar, then right click a bookmark on it. This is breaking because we hide the menu, and then return early when there is no selection attribute and reuse t he hidden state, meaning we will never show the 'copy' item again. This also affects the bookmarks manager. Re-checking my patch,  I don't know why I removed selection=any, so I put it back, which should fix this.

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8627347 [details] [diff] [review]
Patch

Review of attachment 8627347 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/13be016459e1

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/13be016459e1

Comment 8

[Saheda Reza [:Antora]]

Once I copy a bookmark from the bookmark bar and paste that on the bar, the copy context menu becomes unavailable for any bookmark on that bar, found this on :

Build ID 	20150625030202
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:41.0) Gecko/20100101 Firefox/41.0

and this looks fixed on :

Build ID 	20150701030207
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:42.0) Gecko/20100101 Firefox/42.0

Suggesting STATUS -> VERIFIED FIXED

Comment 9

[Kavipriya.A]

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]: Bug Verified.

status-firefox51: Fixed

Comment 10

[:Gijs (he/him)]

(In reply to Kavipriya.A from comment #9)
> [Tracking Requested - why for this release]:
> 
> [Tracking Requested - why for this release]: Bug Verified.
> 
> status-firefox51: Fixed

This bug was already marked verified. Please don't change the release tracking flags unnecessarily.