1177640 - [Mac] Do not expose HTML table semantics for "layout" tables

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Frédéric Wang (:fredw)]

Follow up of bug 744790.

See bug 744790 comment 0 and bug 744790 comment 5.

Comment 1

[Frédéric Wang (:fredw)]

Attachment: Testcase

Comment 2

[Frédéric Wang (:fredw)]

Attachment: Patch

Comment 3

[Frédéric Wang (:fredw)]

Attachment: Testcase

Comment 4

[Frédéric Wang (:fredw)]

Trying attachment 8667522 [details] with Yura, the layout tables are now indeed rendered with AXGroup objects.

However, this makes nighly crash in accessibilityAttributeValue with the "Attachments" of Bugzilla...

Comment 5

[Frédéric Wang (:fredw)]

Attachment: bugzilla-table.html

Comment 6

[Frédéric Wang (:fredw)]

> Group: core-security

Sorry, I didn't want to make this a security bug.

Comment 7

[Frédéric Wang (:fredw)]

@Marco Can you please try that one:

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-b123129dfc3f/try-macosx64/firefox-44.0a1.en-US.mac.dmg

I verified that the crash no longer happens and that the table elements are now presented as AXGroups. However, I don't know if that's what you meant in bug 744790 comment 5.

Comment 8

[Marco Zehe (:MarcoZ)]

Yes, this works like I would expect now.

Comment 9

[alexander :surkov (:asurkov)]

Comment on attachment 8667402 [details] [diff] [review]
Patch

Review of attachment 8667402 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/mac/mozAccessible.mm
@@ +223,5 @@
>  
>    NS_OBJC_END_TRY_ABORT_BLOCK_RETURN(NO);
>  }
>  
> +- (BOOL)isComponentOfLayoutTable

nit: might be nice to name if isLayoutTablePart to make it sync with nsAccessibilityService names

@@ +241,5 @@
> +      table = accWrap->AsTableCell()->Table();
> +    }
> +    if (table && table->IsProbablyLayoutTable()) {
> +      return true;
> +    }

nit: return false; and no else

@@ +939,5 @@
>    }
>  
> +  if ([self isComponentOfLayoutTable]) {
> +    return NSAccessibilityGroupRole;
> +  }

I wish we had something nicer than checking table stuff for each role.

Comment 10

[Frédéric Wang (:fredw)]

Attachment: Patch V2

Comment 11

[Frédéric Wang (:fredw)]

Attachment: Patch V3

Comment 12

[Frédéric Wang (:fredw)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=45bd8cd8985e

(In reply to alexander :surkov from comment #9)
> I wish we had something nicer than checking table stuff for each role.

This will be handled in bug 1178272.

Comment 13

[Frédéric Wang (:fredw)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=45bd8cd8985e

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96f19a715e61

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/96f19a715e61