Closed
Bug 1177709
Opened 9 years ago
Closed 9 years ago
browser-content.js, line 600: TypeError: setting a property that has only a getter
Categories
(Toolkit :: Find Toolbar, defect)
Toolkit
Find Toolbar
Tracking
()
RESOLVED
FIXED
mozilla44
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file, 1 obsolete file)
JavaScript strict warning: chrome://global/content/browser-content.js, line 585: TypeError: setting a property that has only a getter
Seeing this a lot recently.
|
Assignee | |
Updated•9 years ago
|
Component: Conversation → Find Toolbar
Product: Instantbird → Toolkit
Summary: browser-content.js, line 585: TypeError: setting a property that has only a getter → browser-content.js, line 600: TypeError: setting a property that has only a getter
Version: trunk → Trunk
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8666497 -
Flags: review?(dtownsend)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8666497 [details] [diff] [review]
browser-content.js, line 600: TypeError: setting a property that has only a getter
Review of attachment 8666497 [details] [diff] [review]:
-----------------------------------------------------------------
Rather than needing to override the getter we should just remove it and set the property in FindBar.init().
Attachment #8666497 -
Flags: review?(dtownsend) → review-
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8666980 -
Flags: review?(dtownsend)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8666497 -
Attachment is obsolete: true
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8666980 [details] [diff] [review]
Avoid a TypeError in browser-content.js by making the _findAsYouType getter a normal property
Review of attachment 8666980 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks
Attachment #8666980 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f6d1b40dcb74ce14584ed505dc212cea61566f2
Bug 1177709 - Avoid a TypeError in browser-content.js by making the _findAsYouType getter a normal property. r=mossop
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
It appears to me this has a slight behaviour change, in that now the pref is read only once at init time. I am not sure how often init is run so maybe it is not important.
|
||
Comment 7•9 years ago
|
||
|
|
Assignee | |
Comment 8•9 years ago
|
||
(In reply to :aceman from comment #6)
> It appears to me this has a slight behaviour change, in that now the pref is
> read only once at init time. I am not sure how often init is run so maybe it
> is not important.
No, there's a pref observer: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/findbar.xml#313
You need to log in
before you can comment on or make changes to this bug.
Description
•