browser-content.js, line 600: TypeError: setting a property that has only a getter

RESOLVED FIXED in mozilla44

Status

()

--
minor
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

Trunk
mozilla44
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
JavaScript strict warning: chrome://global/content/browser-content.js, line 585: TypeError: setting a property that has only a getter

Seeing this a lot recently.
(Assignee)

Updated

3 years ago
Component: Conversation → Find Toolbar
Product: Instantbird → Toolkit
Summary: browser-content.js, line 585: TypeError: setting a property that has only a getter → browser-content.js, line 600: TypeError: setting a property that has only a getter
Version: trunk → Trunk
(Assignee)

Comment 1

3 years ago
Created attachment 8666497 [details] [diff] [review]
browser-content.js, line 600: TypeError: setting a property that has only a getter
(Assignee)

Updated

3 years ago
Assignee: nobody → aleth
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Attachment #8666497 - Flags: review?(dtownsend)
Comment on attachment 8666497 [details] [diff] [review]
browser-content.js, line 600: TypeError: setting a property that has only a getter

Review of attachment 8666497 [details] [diff] [review]:
-----------------------------------------------------------------

Rather than needing to override the getter we should just remove it and set the property in FindBar.init().
Attachment #8666497 - Flags: review?(dtownsend) → review-
(Assignee)

Comment 3

3 years ago
Created attachment 8666980 [details] [diff] [review]
Avoid a TypeError in browser-content.js by making the _findAsYouType getter a normal property
Attachment #8666980 - Flags: review?(dtownsend)
(Assignee)

Updated

3 years ago
Attachment #8666497 - Attachment is obsolete: true
Comment on attachment 8666980 [details] [diff] [review]
Avoid a TypeError in browser-content.js by making the _findAsYouType getter a normal property

Review of attachment 8666980 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks
Attachment #8666980 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f6d1b40dcb74ce14584ed505dc212cea61566f2
Bug 1177709 - Avoid a TypeError in browser-content.js by making the _findAsYouType getter a normal property. r=mossop
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

Comment 6

3 years ago
It appears to me this has a slight behaviour change, in that now the pref is read only once at init time. I am not sure how often init is run so maybe it is not important.
(Assignee)

Comment 8

3 years ago
(In reply to :aceman from comment #6)
> It appears to me this has a slight behaviour change, in that now the pref is
> read only once at init time. I am not sure how often init is run so maybe it
> is not important.

No, there's a pref observer: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/findbar.xml#313
You need to log in before you can comment on or make changes to this bug.