Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Posted patch PatchSplinter Review
Attachment #8626650 - Flags: review?(jorendorff)
(Assignee)

Updated

4 years ago
No longer blocks: 952650
(Assignee)

Comment 1

4 years ago
Comment on attachment 8626650 [details] [diff] [review]
Patch

Actually jorendorff probably has other patches to review so forwarding to Tom.
Attachment #8626650 - Flags: review?(jorendorff) → review?(evilpies)
Comment on attachment 8626650 [details] [diff] [review]
Patch

Review of attachment 8626650 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi-tests/testArgumentsObject.cpp
@@ +93,5 @@
>              CHECK(argsobj->maybeGetElements(i, j, elems.begin()));
>              for (size_t k = 0; k < j; k++)
>                  CHECK_SAME(elems[k], INT_TO_JSVAL(i + k));
>              for (size_t k = j; k < MAX_ELEMS - 1; k++)
> +                CHECK_SAME(elems[k], JS::NullValue());

I think we could use CHECK(elems[k].isNull()) here and in the other JSAPI tests.
Attachment #8626650 - Flags: review?(evilpies) → review+
https://hg.mozilla.org/mozilla-central/rev/67d1702bfb1f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.