Closed Bug 1177825 Opened 10 years ago Closed 10 years ago

Remove JSVAL_* constants

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
No description provided.
Attachment #8626650 - Flags: review?(jorendorff)
No longer blocks: 952650
Comment on attachment 8626650 [details] [diff] [review] Patch Actually jorendorff probably has other patches to review so forwarding to Tom.
Attachment #8626650 - Flags: review?(jorendorff) → review?(evilpies)
Comment on attachment 8626650 [details] [diff] [review] Patch Review of attachment 8626650 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsapi-tests/testArgumentsObject.cpp @@ +93,5 @@ > CHECK(argsobj->maybeGetElements(i, j, elems.begin())); > for (size_t k = 0; k < j; k++) > CHECK_SAME(elems[k], INT_TO_JSVAL(i + k)); > for (size_t k = j; k < MAX_ELEMS - 1; k++) > + CHECK_SAME(elems[k], JS::NullValue()); I think we could use CHECK(elems[k].isNull()) here and in the other JSAPI tests.
Attachment #8626650 - Flags: review?(evilpies) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: