1177839 - Trying to load about:reader from the URL bar causes Firefox to crash

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

STR:
Open Firefox
Type "about:reader" in the location bar and press enter

Firefox crashes!

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

/GeckoCrashHandler(12431): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1437 ("GeckoBackgroundThread")
E/GeckoCrashHandler(12431): java.lang.IllegalArgumentException: the bind value at index 2 is null
E/GeckoCrashHandler(12431): 	at android.database.sqlite.SQLiteProgram.bindString(SQLiteProgram.java:164)
E/GeckoCrashHandler(12431): 	at android.database.sqlite.SQLiteProgram.bindAllArgsAsStrings(SQLiteProgram.java:200)
E/GeckoCrashHandler(12431): 	at android.database.sqlite.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDriver.java:47)
E/GeckoCrashHandler(12431): 	at android.database.sqlite.SQLiteDatabase.rawQueryWithFactory(SQLiteDatabase.java:1316)
E/GeckoCrashHandler(12431): 	at android.database.sqlite.SQLiteQueryBuilder.query(SQLiteQueryBuilder.java:400)
E/GeckoCrashHandler(12431): 	at android.database.sqlite.SQLiteQueryBuilder.query(SQLiteQueryBuilder.java:333)
E/GeckoCrashHandler(12431): 	at org.mozilla.gecko.db.ReadingListProvider.query(ReadingListProvider.java:382)
E/GeckoCrashHandler(12431): 	at android.content.ContentProvider.query(ContentProvider.java:966)
E/GeckoCrashHandler(12431): 	at android.content.ContentProvider$Transport.query(ContentProvider.java:211)
E/GeckoCrashHandler(12431): 	at android.content.ContentResolver.query(ContentResolver.java:478)
E/GeckoCrashHandler(12431): 	at android.content.ContentResolver.query(ContentResolver.java:422)
E/GeckoCrashHandler(12431): 	at org.mozilla.gecko.db.LocalReadingListAccessor.isReadingListItem(LocalReadingListAccessor.java:79)
E/GeckoCrashHandler(12431): 	at org.mozilla.gecko.Tab$5.run(Tab.java:541)
E/GeckoCrashHandler(12431): 	at android.os.Handler.handleCallback(Handler.java:739)
E/GeckoCrashHandler(12431): 	at android.os.Handler.dispatchMessage(Handler.java:95)
E/GeckoCrashHandler(12431): 	at android.os.Looper.loop(Looper.java:135)
E/GeckoCrashHandler(12431): 	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:43)
E/GeckoCrashHandler(12431): Main thread (1) stack:
E/GeckoCrashHandler(12431):     android.os.BinderProxy.transactNative(Native Method)
E/GeckoCrashHandler(12431):     android.os.BinderProxy.transact(Binder.java:496)
E/GeckoCrashHandler(12431):     android.os.IUserManager$Stub$Proxy.getUserRestrictions(IUserManager.java:704)
E/GeckoCrashHandler(12431):     android.os.UserManager.getUserRestrictions(UserManager.java:585)
E/GeckoCrashHandler(12431):     android.os.UserManager.getUserRestrictions(UserManager.java:575)
E/GeckoCrashHandler(12431):     org.mozilla.gecko.RestrictedProfiles.getRestrictions(RestrictedProfiles.java:101)
E/GeckoCrashHandler(12431):     org.mozilla.gecko.RestrictedProfiles.getRestriction(RestrictedProfiles.java:120)
E/GeckoCrashHandler(12431):     org.mozilla.gecko.RestrictedProfiles.isAllowed(RestrictedProfiles.java:203)
E/GeckoCrashHandler(12431):     org.mozilla.gecko.RestrictedProfiles.isAllowed(RestrictedProfiles.java:174)
E/GeckoCrashHandler(12431):     org.mozilla.gecko.BrowserApp.onPrepareOptionsMenu(BrowserApp.java:3252)
E/GeckoCrashHandler(12431):     org.mozilla.gecko.GeckoApp.invalidateOptionsMenu(GeckoApp.java:314)
E/GeckoCrashHandler(12431):     org.mozilla.gecko.GeckoApp.onTabChanged(GeckoApp.java:286)
E/GeckoCrashHandler(12431):     org.mozilla.gecko.BrowserApp.onTabChanged(BrowserApp.java:527)
E/GeckoCrashHandler(12431):     org.mozilla.gecko.Tabs$5.run(Tabs.java:667)
E/GeckoCrashHandler(12431):     android.os.Handler.handleCallback(Handler.java:739)
E/GeckoCrashHandler(12431):     android.os.Handler.dispatchMessage(Handler.java:95)
E/GeckoCrashHandler(12431):     android.os.Looper.loop(Looper.java:135)
E/GeckoCrashHandler(12431):     android.app.ActivityThread.main(ActivityThread.java:5254)
E/GeckoCrashHandler(12431):     java.lang.reflect.Method.invoke(Native Method)
E/GeckoCrashHandler(12431):     java.lang.reflect.Method.invoke(Method.java:372)
E/GeckoCrashHandler(12431):     com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
E/GeckoCrashHandler(12431):     com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
F/libc    (12431): Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 12447 (GeckoBackground)

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1177839 - Don't return null from stripURI. r=sebastian

Bug 1177839 - Don't return null from stripURI. r=sebastian

Comment 3

[:Margaret Leibovic]

Comment on attachment 8626692 [details]
MozReview Request: Bug 1177839 - Don't return null from stripURI. r=sebastian

Bug 1177839 - Don't return null from stripURI. r=sebastian

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

https://reviewboard.mozilla.org/r/12111/#review10633

::: mobile/android/base/db/LocalReadingListAccessor.java:212
(Diff revision 2)
> +        return (strippedUrl) != null ? strippedUrl : uri;

nit: The braces around strippedUrl shouldn't be needed?

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8626692 [details]
MozReview Request: Bug 1177839 - Don't return null from stripURI. r=sebastian

https://reviewboard.mozilla.org/r/12113/#review10635

Ship It!

Comment 6

[:Margaret Leibovic]

(In reply to :Sebastian Kaspari from comment #4)
> https://reviewboard.mozilla.org/r/12111/#review10633
> 
> ::: mobile/android/base/db/LocalReadingListAccessor.java:212
> (Diff revision 2)
> > +        return (strippedUrl) != null ? strippedUrl : uri;
> 
> nit: The braces around strippedUrl shouldn't be needed?

Oops, that was probably just some leftover cruft from changing things around.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/09d0daf906f3

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/09d0daf906f3

Comment 9

[Teodora Vermesan (:TeoVermesan)]

Nightly doesn't crash when loading "about:reader" anymore. It will display "about:blank" in URL Bar.
Tested with:
Device: Nexus 4 (Android 5.1)
Build: Firefox for Android 42.0a1 (2015-07-19)