1177857 - Treeherder job spans should be buttons for a11y

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[William Lachance (:wlach)]

For screen readers, it would be useful if the job elements were buttons, instead of spans. This is an easy change to make, so we should just do it.

Comment 1

[William Lachance (:wlach)]

Attachment: PR

Comment 2

[Jonathan French (:jfrench)]

Comment on attachment 8626690 [details] [review]
PR

r+ in advance for Will assuming a suitable transparency tweak for non-failed selected jobs.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b34fbb589fe699220f68f6363edaf95f827657ca
Bug 1177857 - Make job elements buttons instead of spans, for a11y

Comment 4

[William Lachance (:wlach)]

Just needed to shuffle some CSS to fix the transparency issue. Pushed afterwards.

Comment 5

[Jonathan French (:jfrench)]

Attachment: manualSelectionAppearancePostPR

I didn't notice this testing the first iteration of the PR, but RyanVM noticed the landed iteration on production this morning. When manually selecting the new a11y job buttons we (or the browser) draws them in quite different styles to its former span approach, and also different to using the n,p keys. See attached.

It might be nice if we could draw them the same as they were before, consistently with the two workflows, and sans the browser btn stylings. Currently a dashed btn on Firefox, a haloed btn on Chrome, and a dark background.