1177896 - MOZ_PATH_PROG trusts env overrides

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

Attachment: Fail MOZ_PATH_PROG* if env override doesn't point to a real file

Testing the rust stuff I noticed that if one sets an absolute path environment override for a variable set by AC_PATH_PROG*, it will trust it without verification. If the override points to an invalid location, configure will succeed, but the build will fail later when the program in invoked.

Since we have a wrapper (MOZ_PATH_PROG*) it might be nice to fail at configure time for faster test turn-around.

Comment 1

[Ralph Giles (:rillian)]

NB we may not be able to do this currently; it looks like some integration builds run configure _before_ tooltool. That's incorrect of course, but this patch would break such builds if they rely on stuff installed after configure is run.

Comment 2

[Ralph Giles (:rillian)]

I don't think this is worth fixing.

Comment 3

[(not currently active) Ted Mielczarek]

This will get fixed when we port the Rust bits of configure to moz.configure, since the MOZ_PATH_PROG replacement actually checks these things.