11779 - TitledButton does not resize itself in displaying CJK texts

Status: RESOLVED INVALID

(Core :: Layout: Form Controls, defect, P3)

Description

[tao]

Too reproduce this:

1. You need to have CJK font installed on your Linux box. Momoi-san can help
   you with this.
2. Run apprunner.
3. Click on "QA|StringBundle Test". It will show a test page with three
   TitleButtons at the bottom.
4. Click on the middle one. It will reset the label string of those buttons.

   You can see that the Japanese text in the right button goes out of the
   buttomFrame. This shows two problems:

     4.1. The button frame does not correctly clip its content.
     4.2. The button frame does not re-adjust it height to accommodate the
          new content.


Feel free to let me know if you have difficulty reproducing the bug.

Hi, Bom-Sheek and Momoi-san:

Have you seen this in other widgets?



Thanks

Comment 1

[Kevin McCluskey (gone)]

Eric,
This is what I was seeing for the html buttons, until I rewrote it using the
HTML4 button.

Eric, reassigning to you.

Comment 2

[bobj]

cc'd erik.

Comment 3

[Erik van der Poel]

This has to do with the fact that Japanese fonts are often much taller than
English fonts. When the string is changed to a Japanese string, the font metrics
object may still be returning the height of the English font. This could be
considered a bug in the font metrics code. Or we could add a string height API
similar to the GetWidth method. I have discussed this with peterl before, but
we didn't reach a conclusion. Adding peterl.

Comment 4

[leger]

Adding [e-mail] to cc list.

Comment 5

[Chris Petersen]

Not sure how I can verify this fix. Reporter, could you please verify this bug ?

Comment 6

[msanz]

reassigning QA contact

Comment 7

[tao]

I looked at the nov-12-08 Linux build and found that the Chinese texts now are
contained within the titled buttons. However, the height of the buttons did not
grow. It seems to be the default size of the button are tall enough for the
Chinese characters already. The result is that there is no spacing between
the Chinese charactes and the top borders of the buttons.

Reopen the bug. But reduce the severity to normal.

To reprodce it, you need to place the attached strres-test.{xul,js} in
chrome/global/content and strres.properties in chrome/global/locale.

Feel free to let me know if you can't reproduce the problem.

Comment 8

[tao]

Attachment: strres-test.xul

Comment 9

[tao]

Attachment: strres-test.js

Comment 10

[tao]

Attachment: strres-test.dtd

Comment 11

[tao]

Attachment: strres.properties

Comment 12

[leger]

Clearing FIXED resolution due to reopen.

Comment 13

[Peter Trudelle]

Mass-moving non-PDT+ bugs to M13

Comment 14

[Erik van der Poel]

This bug will probably be fixed as a side effect of fixing bug 20394. That bug
calls for a change to the gfx APIs, which will result in changes to the callers,
including TitledButton.

Comment 15

[Eric Vaughan]

This bug is dependent on bug #20394. We must be able to get the proper font
size to figure out how big to make the button.

Comment 16

[Eric Vaughan]

pushing to m14

Comment 17

[Eric Vaughan]

This will be fixed when GFX supports this.

Comment 18

[tao]

Hi, Erik:

I can help test the fix if you provide the patch.

Comment 19

[Jim Roskind]

With no visible progress on the dependent bug.. it was changed to PDT-, so I'm 
pushing this to PDT- for beta1 as well.

Comment 20

[Erik van der Poel]

David, is it true that TitledButton will be replaced by something else soon?

Comment 21

[David Hyatt]

Yes.

Comment 22

[tao]

These bugs are prerequisites of our beta2 localization plan. Add "beta2" 
to keyword.

Comment 23

[leger]

Putting on beta2 keyword radar since this was "plus for beta2" during beta1 
triaging

Comment 24

[David Hyatt]

This bug should be invalidated.  titledbutton is deprecated and all uses of it 
will be removed by beta2.

Comment 25

[Erik van der Poel]

Removing beta1 and beta2 keywords; removing PDT- and beta2+ from status
whiteboard; marking INVALID. Do not reopen this bug. Remove TITLEDBUTTONs from
sources. If there are any other types of widgets with this type of problem,
please open separate bugs. Thanks.