1177968 - remove dom.caches.enabled pref

Status: RESOLVED FIXED

(Core :: Storage: Cache API, task, P5)

Description

[Ben Kelly [:bkelly, not reviewing]]

After Caches API has been in release for a cycle or two we should remove dom.caches.enabled pref completely.

Comment 1

[Alex]

Here's a good reason NOT to remove it:
https://github.com/Tampermonkey/tampermonkey/issues/773

Comment 2

[Jens Stutte [:jstutte]]

(In reply to Alex from comment #1)

Here's a good reason NOT to remove it:
https://github.com/Tampermonkey/tampermonkey/issues/773

Hi Alex, if you suspect a bug in Firefox itself causing this issue, could you please file a new bug with clear STR for this specific problem here in bugzilla? Thank you!

Comment 3

[Alex]

(In reply to Jens Stutte [:jstutte] from comment #2)

Hi Alex, if you suspect a bug in Firefox itself causing this issue, could you please file a new bug with clear STR for this specific problem here in bugzilla? Thank you!

Hello Jens,

I opened bug https://bugzilla.mozilla.org/show_bug.cgi?id=1643405 based on reports on TamperMonkey github.

That said, given my experience with the bug system (searching for solutions for problems I encountered with FF only to find out that those are bugs that have been reported seven years ago, for example: #866522 and #850906) I respectfully request that the existing workaround not be removed until the underlying issue is addressed.

Thank you,
Alex.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

Hey Andrew, does this also fall into the emergency pref area? https://bugzilla.mozilla.org/show_bug.cgi?id=1488583#c0 removed the pref for IndexedDB arguing that cookies and site data permissions are sufficient, but it seems it's been replaced by ETP.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

I think we can probably remove the cache API preference as the risk profile is low (and resembles that of IndexedDB's rationale in bug 1488583 although this pref hasn't caused crashes that I know of). I think we'll want to continue to have the service workers enabling pref, though, as its moving parts do have a higher risk profile (in the abstract). Thanks for proactively looking at this!

Comment 6

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

Thanks! I just found this while looking at longstanding issues.

Edit: This one is simpler as it actually hides the relevant attributes/interfaces while the IndexedDB one did not.

Comment 7

[Gregory Pappas [:gregp]]

Attachment: Bug 1177968 - Remove dom.caches.enabled pref r?#dom-worker-reviewers!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9db33f9464a6
Remove dom.caches.enabled pref r=webidl,devtools-reviewers,saschanaz,asuth

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9db33f9464a6