Closed Bug 1178076 Opened 4 years ago Closed 4 years ago

MessagePort should not set listeners nor workerFeature when neutered

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed
firefox42 --- affected

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch mp3.patch (obsolete) — Splinter Review
Attachment #8626991 - Flags: review?(bugs)
Comment on attachment 8626991 [details] [diff] [review]
mp3.patch

It is not obvious what the test is testing, especially the
'new MessageChannel' in onmessage handler. Could you add some comment there.


(I guess need to make sure to either land this before the merge or land to aurora too)
Comment on attachment 8626991 [details] [diff] [review]
mp3.patch

So, would like to see a new patch.
Attachment #8626991 - Flags: review?(bugs) → review-
Attached patch mp3.patchSplinter Review
Comment added. Basically the test itself does nothing expect sending a neutered port to the same window. This should not leak.
Attachment #8626991 - Attachment is obsolete: true
Attachment #8627181 - Flags: review?(bugs)
Attachment #8627181 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/f8de1464929b
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.