1178141 - Animated background image behind other layers is being needlessly painted/repainted

Status: RESOLVED WORKSFORME

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Mikel]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150628030215

Steps to reproduce:

1) Enter https://www.microsoft.com
2) Open developer tools and enable the repaint picker.
3) Observe that a small square is being repainted repeatedly in the center of the slide on top of the page, even when the slides aren't changing.


Actual results:

A small square is being repainted repeatedly in the center of the slide on top of the page, even when the slides on the page aren't changing.


Expected results:

There should be only 1 repaint when the slides change.

Comment 1

[Mikel]

repaint picker = "Highlight painted area" button.

Comment 2

[:Gijs (he/him)]

This is because the <div class="media"> that is a few levels of DOM up from the actual slide image has this style:

.media {
    background-color: #F0F0F0;
    background-image: url("/CMSImages/progressIndicator40x40.gif?version=22bf30a9-5751-70e3-2c7d-7173410d2ed0");
    background-repeat: no-repeat;
    background-position: center center;
    line-height: 0;
    overflow: hidden;
}

That gif is animated, and keeps being repainted. I don't know why; it's fully occluded by the opaque images above it.

Of course, I don't know how long the MS homepage will look like this, so ideally we should try to have a more permanent testcase...

Comment 3

[:Gijs (he/him)]

(Not 100% sure this is the right component, but I expect someone will move further if necessary.)

Comment 4

[:Gijs (he/him)]

http://output.jsbin.com/yasecasifa/1

seems like a simple testcase which produces the same issue for me on 39 beta and Nightly.


dholbert/seth, can you comment as to what is going on here and/or move as appropriate?

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: reduced testcase 1

Here's a further-reduced testcase, with just an animated background GIF behind an opaque-background div.

Comment 6

[Timothy Nikkel (:tnikkel)]

This is likely because we build a display item for the hidden image and assign it to a layer before we do occlusion culling. So when we go to invalidate there is retained data and it seems as though the image was visible last paint.

To fix this could could store in the retained data if the visible region of the item was empty after occlusion culling, and skip invalidating if the retained data indicates it wasn't visible last paint.

Comment 7

[Mikel]

Added the "Power" meta keyword,
as I believe this can affect power consumption on other sites as well.

Feel free to prove me wrong and delete it.

Comment 8

[Nicholas Nethercote [inactive]]

bbirtles says this *might* be covered by bug 1166500.

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to Nicholas Nethercote [inactive] from comment #8)

bbirtles says this might be covered by bug 1166500.

And bug 1237454 has been fixed.
Do you still see this problem?

Comment 10

[Mikel]

I can't actually find the repaint picker this time, was it removed from FF?

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:emilio, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Doesn't seem there's much going on using the profiler on that page.