1178234 - Remove the concept of repository version (eg gecko milestone)

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

This is something that is now surfaced via hg.m.o's json API & I don't think is something we should track in Treeherder. To my knowledge it's unused in Treeherder.

Comment 1

[Ed Morley [:emorley]]

Attachment: Remove repository_version

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/6b1e4f602bafa7c8738c1dffe6f211233bfbcc1f
Bug 1178234 - Remove repository_version

Since it's unused, and hg.mozilla.org now has this information available
via its API.

Note: This commit depends on bug 1178719, to prevent issues during
deployment. Also, due to https://code.djangoproject.com/ticket/25036 a
migrate will need to be run interactively after deployment, to clean up
the old repositoryversion content type.

Comment 3

[Ed Morley [:emorley]]

[[e-mail]3 ~]$ cd /data/www/treeherder.allizom.org/treeherder-service/
[[e-mail]3 treeherder-service]$ ../venv/bin/python ./manage.py migrate
Operations to perform:
  Synchronize unmigrated apps: corsheaders, rest_framework_swagger, workers, rest_framework, embed, rest_framework_extensions
  Apply all migrations: sessions, admin, sites, auth, contenttypes, model
Synchronizing apps without migrations:
  Creating tables...
  Installing custom SQL...
  Installing indexes...
Running migrations:
  No migrations to apply.
The following content types are stale and need to be deleted:

    model | repositoryversion

Any objects related to these content types by a foreign key will also
be deleted. Are you sure you want to delete these content types?
If you're unsure, answer 'no'.

    Type 'yes' to continue, or 'no' to cancel: yes

[[e-mail]3 treeherder-service]$ ../venv/bin/python ./manage.py dbshell
<snip>
mysql> SELECT table_schema, table_name FROM information_schema.tables WHERE table_name = 'repository_version';
+------------------+--------------------+
| table_schema     | table_name         |
+------------------+--------------------+
| treeherder_stage | repository_version |
+------------------+--------------------+
1 row in set (0.00 sec)

mysql> DROP TABLE treeherder_stage.repository_version;
Query OK, 0 rows affected (0.17 sec)

mysql> SELECT table_schema, table_name FROM information_schema.tables WHERE table_name = 'repository_version';
Empty set (0.00 sec)

Comment 4

[Ed Morley [:emorley]]

And prod:

[[e-mail]3 treeherder-service]$ ../venv/bin/python ./manage.py migrate
Operations to perform:
  Synchronize unmigrated apps: corsheaders, rest_framework_swagger, workers, rest_framework, embed, rest_framework_extensions
  Apply all migrations: sessions, admin, sites, auth, contenttypes, model
Synchronizing apps without migrations:
  Creating tables...
  Installing custom SQL...
  Installing indexes...
Running migrations:
  No migrations to apply.
The following content types are stale and need to be deleted:

    model | repositoryversion

Any objects related to these content types by a foreign key will also
be deleted. Are you sure you want to delete these content types?
If you're unsure, answer 'no'.

    Type 'yes' to continue, or 'no' to cancel: yes

[[e-mail]3 treeherder-service]$ ../venv/bin/python ./manage.py dbshell

mysql> DROP TABLE treeherder.repository_version;
Query OK, 0 rows affected (0.19 sec)

mysql> SELECT table_schema, table_name FROM information_schema.tables WHERE table_name = 'repository_version';
Empty set (0.05 sec)

Comment 5

[Ed Morley [:emorley]]

[~/src/treeherder]$ heroku run './manage.py migrate'
Running `./manage.py migrate` attached to terminal... up, run.5349
Operations to perform:
  Synchronize unmigrated apps: embed, rest_framework_extensions, workers, corsheaders, rest_framework, rest_framework_swagger
  Apply all migrations: contenttypes, sites, sessions, auth, admin, model
Synchronizing apps without migrations:
  Creating tables...
  Installing custom SQL...
  Installing indexes...
Running migrations:
  No migrations to apply.
The following content types are stale and need to be deleted:

    model | machinenote
    model | repositoryversion

Any objects related to these content types by a foreign key will also
be deleted. Are you sure you want to delete these content types?
If you're unsure, answer 'no'.

    Type 'yes' to continue, or 'no' to cancel: yes

Run using mysqlworkbench (since dbshell doesn't work on the dynos due to mysql not being on path or present):

DROP TABLE treeherder.repository_version;