1178246 - The function 'PasswordInjector()' in PasswordHelper.js was never called

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect)

Description

[k]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.130 Safari/537.36

Steps to reproduce:

There's a function PasswordInjector() that defined in PasswordHelper.js was never called. However, a line of code 'window.__firefox__.logins = new LoginInjector()' was trying to call a function that doesn't exist.

I found that there's a ticket 'Bug 1171732 - Update passwords when they're used' was related with this bug.


Actual results:

The username and password form on webpages could not be auto filled.


Expected results:

PasswordInjector() should be renamed to LoginInjector()

Comment 1

[Aaron Train [:aaronmt]]

Re: 

> The username and password form on webpages could not be auto filled.

Tracking?

Comment 2

[Richard Newman [:rnewman]]

Well, that explains why I'm not seeing passwords filled :)

Comment 3

[Richard Newman [:rnewman]]

Attachment: Pull req.

This should fix it. Untested, though.

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8627520 [details] [review]
Pull req.

Tried this out with my LDAP login and it autofills correctly.

Comment 5

[Richard Newman [:rnewman]]

Merged.

c16372a041de5aca48e9c64e2f540d7308b2dd8c