Closed Bug 1178331 Opened 5 years ago Closed 3 years ago

kill ship it notifier

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: rail)

References

Details

Attachments

(3 files)

58 bytes, text/x-review-board-request
Callek
: review+
Details
58 bytes, text/x-review-board-request
Callek
: review+
Details
49 bytes, text/x-github-pull-request
Sylvestre
: review+
Callek
: feedback+
Details | Review
Nobody looks at its results, and Taskcluster provides a better UI anyways...
back to the pool for now
Assignee: rail → nobody
Assignee: nobody → rail
Comment on attachment 8768751 [details]
Bug 1178331 - Kill ship-it notifier

https://reviewboard.mozilla.org/r/62822/#review59714

r- for two reasons, though only the first needs to block.

The removal of this from puppet won't stop it running or remove it from the related hosts... you probably want to get rid of it off the hosts with puppet first.

The second issue, (which I don't feel needs to block) is that just this week I learned about the view in ship-it this populates, by thunderbird people, who were actually using said view. So we may want to wait for TB to be in release promotion, or at least tell them that this is going away.
Attachment #8768751 - Flags: review?(bugspam.Callek) → review-
(In reply to Justin Wood (:Callek) from comment #6)
> Comment on attachment 8768751 [details]
> Bug 1178331 - Kill ship-it notifier
> 
> https://reviewboard.mozilla.org/r/62822/#review59714
> 
> r- for two reasons, though only the first needs to block.
> 
> The removal of this from puppet won't stop it running or remove it from the
> related hosts... you probably want to get rid of it off the hosts with
> puppet first.

I thought about this and the idea is to manually clean up bm81 after the patch lands. Otherwise it'd be a unnecessary 2-step puppet patch. Not sure if I want to spend time writing 2 patches. ;) 

> The second issue, (which I don't feel needs to block) is that just this week
> I learned about the view in ship-it this populates, by thunderbird people,
> who were actually using said view. So we may want to wait for TB to be in
> release promotion, or at least tell them that this is going away.

There is a price for keeping this feature around: code complexity in ship-it (it's WIP); automatic marking releases as shipped, but without setting the shipping date, etc.

Please consider this patch again. ;)
Comment on attachment 8768751 [details]
Bug 1178331 - Kill ship-it notifier

https://reviewboard.mozilla.org/r/62822/#review59726

Given your intent to manually clean up, r+

Can you please e-mail tb-drivers that its gone (noting the url of it in ship-it, since they may not know what "ship-it-notifier" is) And double check that our post-release steps for TB include marking it as shipped in UI
Attachment #8768751 - Flags: review- → review+
Comment on attachment 8772122 [details]
Bug 1178331 - kill ship it notifier

https://reviewboard.mozilla.org/r/65022/#review61992

This does look good otherwise, but please get a puppet patch landed before landing this one.
Attachment #8772122 - Flags: review?(bugspam.Callek) → review+
Attached file Kill functionality
Attachment #8772126 - Flags: review?(bugspam.Callek)
(In reply to Justin Wood (:Callek) from comment #11)
> https://reviewboard.mozilla.org/r/65022/#review61990
> 
> Don't we need to purge from puppet (and the host) first?
> 
> https://dxr.mozilla.org/build-central/source/puppet/modules/shipit_notifier/
> manifests/services.pp#10

yes, I'm going to land the puppet patch first
Comment on attachment 8772126 [details] [review]
Kill functionality

A skim looks good, but I don't know this ship-it code well enough to offer a comprehensive review.
Attachment #8772126 - Flags: review?(bugspam.Callek)
Attachment #8772126 - Flags: review?
Attachment #8772126 - Flags: feedback+
Comment on attachment 8772126 [details] [review]
Kill functionality

need a stamp! :)
Attachment #8772126 - Flags: review? → review?(sledru)
Comment on attachment 8772126 [details] [review]
Kill functionality

Approved in github with some minor changes
Attachment #8772126 - Flags: review?(sledru) → review+
Comment on attachment 8772126 [details] [review]
Kill functionality

deployed!
Attachment #8772126 - Flags: checked-in+
Success!
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.