Status

Release Engineering
Release Automation
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: bhearsum, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Nobody looks at its results, and Taskcluster provides a better UI anyways...
(Assignee)

Comment 1

3 years ago
back to the pool for now
Assignee: rail → nobody
Comment hidden (off-topic)
Comment hidden (off-topic)
(Assignee)

Updated

2 years ago
Assignee: nobody → rail
(Assignee)

Comment 5

2 years ago
Created attachment 8768751 [details]
Bug 1178331 - Kill ship-it notifier

Review commit: https://reviewboard.mozilla.org/r/62822/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62822/
Attachment #8768751 - Flags: review?(bugspam.Callek)
Comment on attachment 8768751 [details]
Bug 1178331 - Kill ship-it notifier

https://reviewboard.mozilla.org/r/62822/#review59714

r- for two reasons, though only the first needs to block.

The removal of this from puppet won't stop it running or remove it from the related hosts... you probably want to get rid of it off the hosts with puppet first.

The second issue, (which I don't feel needs to block) is that just this week I learned about the view in ship-it this populates, by thunderbird people, who were actually using said view. So we may want to wait for TB to be in release promotion, or at least tell them that this is going away.
Attachment #8768751 - Flags: review?(bugspam.Callek) → review-
(Assignee)

Comment 7

2 years ago
(In reply to Justin Wood (:Callek) from comment #6)
> Comment on attachment 8768751 [details]
> Bug 1178331 - Kill ship-it notifier
> 
> https://reviewboard.mozilla.org/r/62822/#review59714
> 
> r- for two reasons, though only the first needs to block.
> 
> The removal of this from puppet won't stop it running or remove it from the
> related hosts... you probably want to get rid of it off the hosts with
> puppet first.

I thought about this and the idea is to manually clean up bm81 after the patch lands. Otherwise it'd be a unnecessary 2-step puppet patch. Not sure if I want to spend time writing 2 patches. ;) 

> The second issue, (which I don't feel needs to block) is that just this week
> I learned about the view in ship-it this populates, by thunderbird people,
> who were actually using said view. So we may want to wait for TB to be in
> release promotion, or at least tell them that this is going away.

There is a price for keeping this feature around: code complexity in ship-it (it's WIP); automatic marking releases as shipped, but without setting the shipping date, etc.

Please consider this patch again. ;)
Comment on attachment 8768751 [details]
Bug 1178331 - Kill ship-it notifier

https://reviewboard.mozilla.org/r/62822/#review59726

Given your intent to manually clean up, r+

Can you please e-mail tb-drivers that its gone (noting the url of it in ship-it, since they may not know what "ship-it-notifier" is) And double check that our post-release steps for TB include marking it as shipped in UI
Attachment #8768751 - Flags: review- → review+
(Assignee)

Comment 9

2 years ago
Created attachment 8772122 [details]
Bug 1178331 - kill ship it notifier

Review commit: https://reviewboard.mozilla.org/r/65022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65022/
Attachment #8772122 - Flags: review?(bugspam.Callek)
Comment on attachment 8772122 [details]
Bug 1178331 - kill ship it notifier

https://reviewboard.mozilla.org/r/65022/#review61992

This does look good otherwise, but please get a puppet patch landed before landing this one.
Attachment #8772122 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 13

2 years ago
Created attachment 8772126 [details] [review]
Kill functionality
Attachment #8772126 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 14

2 years ago
(In reply to Justin Wood (:Callek) from comment #11)
> https://reviewboard.mozilla.org/r/65022/#review61990
> 
> Don't we need to purge from puppet (and the host) first?
> 
> https://dxr.mozilla.org/build-central/source/puppet/modules/shipit_notifier/
> manifests/services.pp#10

yes, I'm going to land the puppet patch first
Comment on attachment 8772126 [details] [review]
Kill functionality

A skim looks good, but I don't know this ship-it code well enough to offer a comprehensive review.
Attachment #8772126 - Flags: review?(bugspam.Callek)
Attachment #8772126 - Flags: review?
Attachment #8772126 - Flags: feedback+
(Assignee)

Comment 16

2 years ago
Comment on attachment 8772126 [details] [review]
Kill functionality

need a stamp! :)
Attachment #8772126 - Flags: review? → review?(sledru)
Comment on attachment 8772126 [details] [review]
Kill functionality

Approved in github with some minor changes
Attachment #8772126 - Flags: review?(sledru) → review+
(Assignee)

Comment 19

2 years ago
Comment on attachment 8772126 [details] [review]
Kill functionality

deployed!
Attachment #8772126 - Flags: checked-in+
(Assignee)

Comment 20

2 years ago
Success!
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.