1178331 - kill ship it notifier

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[[e-mail] (:bhearsum)]

Nobody looks at its results, and Taskcluster provides a better UI anyways...

Comment 1

[Rail Aliiev [:rail]]

back to the pool for now

Comment 2

[Rail Aliiev [:rail]]

Switched it to AMQPS for now.

remote:   https://hg.mozilla.org/build/puppet/rev/bdbab8f63eec
remote:   https://hg.mozilla.org/build/puppet/rev/35dfac744355

Comment 3

[Allan [:asilva]]

In some points the following comparison is made (event_name string contains 'complete'):

if 'complete' not in repack.event_name:
	repacks['platforms'][repack.platform] += (1.00/repack.chunkTotal)
else:
	repacks['platforms'][repack.platform] = 1.00
	
Sorry, I did not understand the relationship beetween the bug 1178331 and this.

Comment 4

[Allan [:asilva]]

Wrong place...

Comment 5

[Rail Aliiev [:rail]]

Attachment: Bug 1178331 - Kill ship-it notifier

Review commit: https://reviewboard.mozilla.org/r/62822/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62822/

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 8768751 [details]
Bug 1178331 - Kill ship-it notifier

https://reviewboard.mozilla.org/r/62822/#review59714

r- for two reasons, though only the first needs to block.

The removal of this from puppet won't stop it running or remove it from the related hosts... you probably want to get rid of it off the hosts with puppet first.

The second issue, (which I don't feel needs to block) is that just this week I learned about the view in ship-it this populates, by thunderbird people, who were actually using said view. So we may want to wait for TB to be in release promotion, or at least tell them that this is going away.

Comment 7

[Rail Aliiev [:rail]]

(In reply to Justin Wood (:Callek) from comment #6)
> Comment on attachment 8768751 [details]
> Bug 1178331 - Kill ship-it notifier
> 
> https://reviewboard.mozilla.org/r/62822/#review59714
> 
> r- for two reasons, though only the first needs to block.
> 
> The removal of this from puppet won't stop it running or remove it from the
> related hosts... you probably want to get rid of it off the hosts with
> puppet first.

I thought about this and the idea is to manually clean up bm81 after the patch lands. Otherwise it'd be a unnecessary 2-step puppet patch. Not sure if I want to spend time writing 2 patches. ;) 

> The second issue, (which I don't feel needs to block) is that just this week
> I learned about the view in ship-it this populates, by thunderbird people,
> who were actually using said view. So we may want to wait for TB to be in
> release promotion, or at least tell them that this is going away.

There is a price for keeping this feature around: code complexity in ship-it (it's WIP); automatic marking releases as shipped, but without setting the shipping date, etc.

Please consider this patch again. ;)

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 8768751 [details]
Bug 1178331 - Kill ship-it notifier

https://reviewboard.mozilla.org/r/62822/#review59726

Given your intent to manually clean up, r+

Can you please e-mail tb-drivers that its gone (noting the url of it in ship-it, since they may not know what "ship-it-notifier" is) And double check that our post-release steps for TB include marking it as shipped in UI

Comment 9

[Rail Aliiev [:rail]]

Attachment: Bug 1178331 - kill ship it notifier

Review commit: https://reviewboard.mozilla.org/r/65022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65022/

Comment 10

[Rail Aliiev [:rail]]

Comment on attachment 8768751 [details]
Bug 1178331 - Kill ship-it notifier

https://hg.mozilla.org/build/puppet/rev/14ff15c9b234
https://hg.mozilla.org/build/puppet/rev/193812bf7659

Comment 11

[Justin Wood (:Callek)]

https://reviewboard.mozilla.org/r/65022/#review61990

Don't we need to purge from puppet (and the host) first?

https://dxr.mozilla.org/build-central/source/puppet/modules/shipit_notifier/manifests/services.pp#10

Comment 12

[Justin Wood (:Callek)]

Comment on attachment 8772122 [details]
Bug 1178331 - kill ship it notifier

https://reviewboard.mozilla.org/r/65022/#review61992

This does look good otherwise, but please get a puppet patch landed before landing this one.

Comment 13

[Rail Aliiev [:rail]]

Attachment: Kill functionality

Comment 14

[Rail Aliiev [:rail]]

(In reply to Justin Wood (:Callek) from comment #11)
> https://reviewboard.mozilla.org/r/65022/#review61990
> 
> Don't we need to purge from puppet (and the host) first?
> 
> https://dxr.mozilla.org/build-central/source/puppet/modules/shipit_notifier/
> manifests/services.pp#10

yes, I'm going to land the puppet patch first

Comment 15

[Justin Wood (:Callek)]

Comment on attachment 8772126 [details] [review]
Kill functionality

A skim looks good, but I don't know this ship-it code well enough to offer a comprehensive review.

Comment 16

[Rail Aliiev [:rail]]

Comment on attachment 8772126 [details] [review]
Kill functionality

need a stamp! :)

Comment 17

[Rail Aliiev [:rail]]

Comment on attachment 8772122 [details]
Bug 1178331 - kill ship it notifier

https://hg.mozilla.org/build/tools/rev/5c4cbb50084a

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8772126 [details] [review]
Kill functionality

Approved in github with some minor changes

Comment 19

[Rail Aliiev [:rail]]

Comment on attachment 8772126 [details] [review]
Kill functionality

deployed!

Comment 20

[Rail Aliiev [:rail]]

Success!