Closed Bug 1178453 Opened 4 years ago Closed 4 years ago

Change logging in storage-json.js to avoid string concatenation

Categories

(Toolkit :: Password Manager, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: MattN, Assigned: rchtara, Mentored)

References

()

Details

(Whiteboard: [lang=js] [good first bug])

Attachments

(1 file, 1 obsolete file)

storage-json.js currently concatenates its arguments to the log function instead of letting Console.jsm do the concatenation and provide cleaner/coloured/inspectable output.

We should convert lines like:
`this.log("Getting login saving is enabled for " + hostname);`
to
`this.log("Getting login saving is enabled for ", hostname);`

to get the output and performance benefits.
(In reply to Matthew N. [:MattN] from comment #0)
> to
> `this.log("Getting login saving is enabled for ", hostname);`

I meant to remove the space at the end of the string too:
`this.log("Getting login saving is enabled for", hostname);`
Mentor: MattN+bmo
Hello!
This the patch for this bug.
Could you please review it?
Thanxs
Attachment #8627885 - Flags: review?(MattN+bmo) → review+
Is there a Try link handy for this change? :)
Keywords: checkin-needed
Hi Ryan,
Unfortunately, I don’t have try access yet.
https://hg.mozilla.org/mozilla-central/rev/7330514ef5e4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.