1178500 - Remove nightly-only flag for voice input

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Karim Benhmida [:karim]]

Voice input is currently only supported in Nightly.
You need to remove the nightly flags in the following files:

- mobile/android/base/preferences/GeckoPreferences.java
- mobile/android/base/toolbar/ToolbarEditLayout.java
- mobile/android/tests/browser/robocop/testSettingsMenuItems.java

Comment 1

[Chenxia Liu [:liuche]]

Karim, I'm also going to assign you to this bug - let's turn on voice in 41!

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

All indications are that Voice Search is ready to ship. Let's get the flag removed, land into nightly and then request uplift to aurora.

Comment 3

[Chenxia Liu [:liuche]]

Yep, I talked to Karim yesterday, and he says he'll be working on this today.

Comment 4

[Karim Benhmida [:karim]]

Attachment: MozReview Request: Bug 1178500 - Remove nightly-only flag for voice input. r=liuche

Bug 1178500 - Remove nightly-only flag for voice input. r=liuche

Comment 5

[Karim Benhmida [:karim]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=408f985ae47a

Comment 6

[Chenxia Liu [:liuche]]

Comment on attachment 8636759 [details]
MozReview Request: Bug 1178500 - Remove nightly-only flag for voice input. r=liuche

https://reviewboard.mozilla.org/r/13697/#review12451

Ship It!

Comment 7

[Karim Benhmida [:karim]]

Tests are green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa77429580ac

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7d2af61675f5

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7d2af61675f5