1178503 - Remove nightly-only flag for QR code input

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Karim Benhmida [:karim]]

QR code input is currently enabled for Nightly only.
You need to remove the nightly flags in the following files:

- mobile/android/base/preferences/GeckoPreferences.java
- mobile/android/base/toolbar/ToolbarEditLayout.java

Comment 1

[:Margaret Leibovic]

Karim, Chenxia, is there anything blocking this? Can we write a patch and uplift it to ship this in 41?

Comment 2

[Chenxia Liu [:liuche]]

Nope, nothing blocking this or the Voice! Just wanted it to bake a bit on Nightly, but we haven't heard of any bugs, so sounds like this should be fine.

Karim, do you want to do this bug, or should I take it?

Comment 3

[Karim Benhmida [:karim]]

I can do it :)

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

I tested a current nightly with the top 10 QR code readers when searching for "QR code" in the Play Store + some ones that caught my eye mostly carriers and security companies. Some don't seem to provide an API for other apps to call into them. All the ones that did provide an API functioned. I think we want to block the Google Goggle's app from this as the experience is poor and it does not directly give Firefox back a URL. It fires an intent then you need to select your browser again.

If anyone has info on popular QR Code readers in non-American non-European countries I would be interested in testing those apps.

Comment 5

[Karim Benhmida [:karim]]

Attachment: MozReview Request: Bug 1178503 - Remove nightly-only flag for QR code input. r=liuche

Bug 1178503 - Remove nightly-only flag for QR code input. r=liuche

Comment 6

[Karim Benhmida [:karim]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=69b9c0e6631f

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 8636763 [details]
MozReview Request: Bug 1178503 - Remove nightly-only flag for QR code input. r=liuche

https://reviewboard.mozilla.org/r/13701/#review12447

Looks good!

Comment 8

[Karim Benhmida [:karim]]

Tests are passing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ed8a90ac7b8

Comment 9

[Carsten Book [:Tomcat]]

Hi, seems this does not apply cleanly:

patching file mobile/android/base/preferences/GeckoPreferences.java
Hunk #1 FAILED at 683
Hunk #2 succeeded at 828 with fuzz 2 (offset 0 lines).
1 out of 2 hunks FAILED -- saving rejects to file mobile/android/base/preferences/GeckoPreferences.java.rej
patching file mobile/android/base/toolbar/ToolbarEditLayout.java
Hunk #1 FAILED at 294
1 out of 1 hunks FAILED -- saving rejects to file mobile/android/base/toolbar/ToolbarEditLayout.java.rej
patch failed to apply
abort: fix up the merge and run hg transplant --continue

could you take a look, thanks!

Comment 10

[Karim Benhmida [:karim]]

I just rebased on top of changeset 254432:9bca608ab65a - date: Fri Jul 24 12:54:13 (merge mozilla-inbound to mozilla-central a=merge) with no errors

Comment 11

[Chenxia Liu [:liuche]]

url:        https://hg.mozilla.org/integration/fx-team/rev/2fef87f7d115774e710e869485e695b79b6f94be
changeset:  2fef87f7d115774e710e869485e695b79b6f94be
user:       Karim Benhmida <[e-mail]>
date:       Tue Jul 21 13:23:57 2015 -0700
description:
Bug 1178503 - Remove nightly-only flag for QR code input. r=liuche

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2fef87f7d115