Closed Bug 1178503 Opened 6 years ago Closed 6 years ago

Remove nightly-only flag for QR code input

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox42 fixed, fennec41+)

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed
fennec 41+ ---

People

(Reporter: karim, Assigned: karim)

References

Details

Attachments

(1 file)

QR code input is currently enabled for Nightly only.
You need to remove the nightly flags in the following files:

- mobile/android/base/preferences/GeckoPreferences.java
- mobile/android/base/toolbar/ToolbarEditLayout.java
Depends on: 602818
Karim, Chenxia, is there anything blocking this? Can we write a patch and uplift it to ship this in 41?
tracking-fennec: --- → ?
Flags: needinfo?(liuche)
Flags: needinfo?(kbenhmida)
Nope, nothing blocking this or the Voice! Just wanted it to bake a bit on Nightly, but we haven't heard of any bugs, so sounds like this should be fine.

Karim, do you want to do this bug, or should I take it?
Flags: needinfo?(liuche)
I can do it :)
Flags: needinfo?(kbenhmida)
Assignee: nobody → kbenhmida
tracking-fennec: ? → 41+
Depends on: 1182220
I tested a current nightly with the top 10 QR code readers when searching for "QR code" in the Play Store + some ones that caught my eye mostly carriers and security companies. Some don't seem to provide an API for other apps to call into them. All the ones that did provide an API functioned. I think we want to block the Google Goggle's app from this as the experience is poor and it does not directly give Firefox back a URL. It fires an intent then you need to select your browser again.

If anyone has info on popular QR Code readers in non-American non-European countries I would be interested in testing those apps.
Bug 1178503 - Remove nightly-only flag for QR code input. r=liuche
Attachment #8636763 - Flags: review?(liuche)
Attachment #8636763 - Flags: review?(liuche) → review+
Comment on attachment 8636763 [details]
MozReview Request: Bug 1178503 - Remove nightly-only flag for QR code input. r=liuche

https://reviewboard.mozilla.org/r/13701/#review12447

Looks good!
Blocks: 1186653
Keywords: checkin-needed
Hi, seems this does not apply cleanly:

patching file mobile/android/base/preferences/GeckoPreferences.java
Hunk #1 FAILED at 683
Hunk #2 succeeded at 828 with fuzz 2 (offset 0 lines).
1 out of 2 hunks FAILED -- saving rejects to file mobile/android/base/preferences/GeckoPreferences.java.rej
patching file mobile/android/base/toolbar/ToolbarEditLayout.java
Hunk #1 FAILED at 294
1 out of 1 hunks FAILED -- saving rejects to file mobile/android/base/toolbar/ToolbarEditLayout.java.rej
patch failed to apply
abort: fix up the merge and run hg transplant --continue

could you take a look, thanks!
Flags: needinfo?(kbenhmida)
Keywords: checkin-needed
I just rebased on top of changeset 254432:9bca608ab65a - date: Fri Jul 24 12:54:13 (merge mozilla-inbound to mozilla-central a=merge) with no errors
Flags: needinfo?(kbenhmida)
url:        https://hg.mozilla.org/integration/fx-team/rev/2fef87f7d115774e710e869485e695b79b6f94be
changeset:  2fef87f7d115774e710e869485e695b79b6f94be
user:       Karim Benhmida <kbenhmida@mozilla.com>
date:       Tue Jul 21 13:23:57 2015 -0700
description:
Bug 1178503 - Remove nightly-only flag for QR code input. r=liuche
https://hg.mozilla.org/mozilla-central/rev/2fef87f7d115
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.