1178550 - rtrim message before displaying

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[arlolra]

Attachment: rtrim.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.130 Safari/537.36

Steps to reproduce:

https://github.com/arlolra/ctypes-otr/issues/54

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8627457 [details] [diff] [review]
rtrim.patch

Review of attachment 8627457 [details] [diff] [review]:
-----------------------------------------------------------------

I'm OK with using regex, but you can also use String.prototype.trimRight (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/TrimRight).

This change will affect Thunderbird too, but I think we have established on IRC that we don't want to support displaying of messages with whitespace intentionally typed at the end.

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8627457 [details] [diff] [review]
rtrim.patch

Review of attachment 8627457 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/content/convbrowser.xml
@@ +512,5 @@
>                this.setUnreadRuler();
>  
> +            // rtrim before displaying. This removes any OTR related
> +            // whitespace when the extension isn't enabled.
> +            let msg = aMsg.displayMessage.replace(/\s+$/, '');

Please use rtrim instead of a regex.

Comment 3

[arlolra]

Attachment: rtrim.patch from comment 2

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8629042 [details] [diff] [review]
rtrim.patch from comment 2

Review of attachment 8629042 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/ff6fe4b9ac9b

Comment 6

[Patrick Cloke [:clokep]]

Updating milestone from 1.6 to 42.