1178606 - [Hackerplace] "Error exporting app" when uploading addon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Hackerplace, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

STR:

1.) create an addon, and install it with WebIDE
2.) Open Hackerplace, and click the upload button
3.) Choose the new addon, and submit the form

Expected Result:
Upload Successful

Actual Result:
Dialog pops up saying ‘error exporting app’.

I've traced the error in Gecko, and it's happening here:
http://hg.mozilla.org/mozilla-central/annotate/13f8dcb5b7a5/dom/apps/ImportExport.jsm#l192

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Any progress here?

Comment 2

[[:fabrice] Fabrice Desré]

(In reply to Michael Henretty [:mhenretty] from comment #1)
> Any progress here?

The upload panel doesn't display anything for me. Is that a recent regression?

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Fabrice Desré [:fabrice] from comment #2)
> (In reply to Michael Henretty [:mhenretty] from comment #1)
> > Any progress here?
> 
> The upload panel doesn't display anything for me. Is that a recent
> regression?

This can happen when you don't have any apps installed that can be uploaded to hackerplace. Installing an app or add-on through webIDE should make it show up here. If, however, you installed something through webIDE and you still see nothing, then this is a bug.

Comment 4

[[:fabrice] Fabrice Desré]

yep I pushed an add-on from webIDE. What's the criteria you use to decide if something is shareable?

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

We make sure it's not one of our blacklisted apps (which is basically spark apps), we make sure it's either an addon or a theme, or if not one of those that it was not installed from the marketplace.

https://github.com/fxos/directory/blob/9e21521a7e0fd6d87b2145af965c8a0c94d302e9/app/js/view/upload_view.js#L58

Comment 7

[[:fabrice] Fabrice Desré]

Well, for some reason this add-on doesn't show up:
"sw-enabler.desre.org": {
    "origin": "app://sw-enabler.desre.org",
    "installOrigin": "app://sw-enabler.desre.org",
    "manifestURL": "app://sw-enabler.desre.org/manifest.webapp",
    "appStatus": 3,
    "receipts": [],
    "kind": "packaged",
    "installTime": 1436070244562,
    "installState": "installed",
    "removable": true,
    "id": "sw-enabler.desre.org",
    "basePath": "/data/local/webapps",
    "localId": 1049,
    "sideloaded": true,
    "name": "Incinerate Add-on",
    "csp": "",
    "role": "addon",
    "redirects": null,
    "widgetPages": [],
    "additionalLanguages": {},
    "enabled": true,
    "installerAppId": 0,
    "installerIsBrowser": false,
    "storeId": "",
    "storeVersion": 0,
    "downloading": false,
    "readyToApplyDownload": false
  }

That doesn't make sense to me...

Comment 8

[[:fabrice] Fabrice Desré]

Attachment: bug1178606.patch

Apps sideloaded from webIDE don't have an update manifest, since they don't really come from a remote source. We handle that gracefully in general, ignoring updates for these apps, but we were too strict about having update.webapp in the import/export code.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/c353ad38b6e8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c353ad38b6e8