1178771 - Shortcut key for filter input

Status: NEW

(DevTools :: JSON Viewer, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

There is no keyboard shortcut for focusing the filter field. When you implement this we should indicate what the shortcut is in the filter field's placeholder text.

We need to figure out which shortcut we could possibly use for this feature.

See also this comment:
https://bugzilla.mozilla.org/show_bug.cgi?id=1132203#c74



Honza

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

One interesting thought I had was: override CMD/Ctrl+F and CMD/Ctrl+G for the page.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Jeff Griffiths (:canuckistani) from comment #1)
> One interesting thought I had was: override CMD/Ctrl+F and CMD/Ctrl+G for
> the page.
I like it!

We could also override only CMD/Ctrl+F, so the other one can be
used to open the find-bar...

Honza

Comment 3

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Jan Honza Odvarko [:Honza] from comment #2)
> (In reply to Jeff Griffiths (:canuckistani) from comment #1)
> > One interesting thought I had was: override CMD/Ctrl+F and CMD/Ctrl+G for
> > the page.
> I like it!
> 
> We could also override only CMD/Ctrl+F, so the other one can be
> used to open the find-bar...

Hrm, CMD/Ctrl+G almost universally means 'find next' - I think if we're going to override we should go all in. Having some shortcuts work like a web page and others custom seems more confusing.

Comment 4

[Zac Svoboda :zacnomore]

This looks like a great feature. It definitely makes sense to me that ctrl + f would work, not sure I understand the part about ctrl + g. Could we get a decision here to move it forward?

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I agree with the comment #3

Let's override CMD/Ctrl+F and CMD/Ctrl+G for the page.

CMD/Ctrl+F - focus the JSON Viewer search box
CMD/Ctrl+G - find next

Comment 6

[Zac Svoboda :zacnomore]

Attachment: Bug 1178771 - Add find shortcuts to json viewer r?jdescottes

Depends on D159547

Comment 7

[Julian Descottes [:jdescottes]]

Hi Alex, I added a question for you on phabricator, just adding the needinfo here to make sure you get the ping :)

Comment 8

[Zac Svoboda :zacnomore]

Holding onto this one for just a little bit longer. Depending on the outcome of bug 1792803 I may be unblocked from using key-shortcuts so I don't want to try landing the hacky version quite yet.

Comment 9

[Alexandre Poirot [:ochameau]]

Just replied on phabricator. I was busy with other things, but I'll try to get bug 1792803 to move forward again. But do not hesitate to workaround for now.

Comment 10

[Zac Svoboda :zacnomore]

Apologies, I'm experiencing health issues and need to step away.