Closed
Bug 1178813
Opened 9 years ago
Closed 9 years ago
Revise the autocomplete_list_bg.9.png asset
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Firefox 42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: mhaigh, Assigned: mhaigh)
References
Details
Attachments
(3 files)
autocomplete_list_bg.9.png
In bug 1171946 comment 4 I discovered that the autocomplete_list_bg.9.png asset (attached) was only defined in mdpi. That bug removes mdpi assets from Fx so we really need new assets in hdpi, xhdi and xxhdpi to replace this one. We can probably create this in XML or at least create a much smaller version of this asset. Either is good.
|
Assignee | |
Updated•9 years ago
|
Summary: make autocomplete_list_bg.9.png in to a drawable xml file → Revise the autocomplete_list_bg.9.png asset
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
||
Comment 2•9 years ago
|
||
Let's just replace this with an XML file, white, and border color can be "text and tab tray grey" (#363B40) for now
|
|
||
Comment 3•9 years ago
|
||
^spoke too soon. That looks too dark, let's go with the Placeholder grey (#777777)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Bug 1178813 - Revise the autocomplete_list_bg.9.png asset; r?mcomella
Attachment #8629348 -
Flags: review?(michael.l.comella)
Comment on attachment 8629348 [details] MozReview Request: Bug 1178813 - Revise the autocomplete_list_bg.9.png asset; r?mcomella https://reviewboard.mozilla.org/r/12579/#review11233 Ship It!
Attachment #8629348 -
Flags: review?(michael.l.comella) → review+
https://reviewboard.mozilla.org/r/12579/#review11233 Just to double-check, the padding between the box and the text is okay, right?
|
|
Assignee | |
Comment 7•9 years ago
|
||
I did a visual check and it seemed fine on my SGS5 - lets land and keep an eye on it to ensure it's good across different configs
|
|
Assignee | |
Comment 8•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=06635eb41655
|
|
Assignee | |
Comment 9•9 years ago
|
||
url: https://hg.mozilla.org/integration/fx-team/rev/ec22db983463c5b52553fda015ed265a8ee8ec37 changeset: ec22db983463c5b52553fda015ed265a8ee8ec37 user: Martyn Haigh <mhaigh@mozilla.org> date: Fri Jul 03 13:59:40 2015 +0100 description: Bug 1178813 - Revise the autocomplete_list_bg.9.png asset r=mcomella
|
||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ec22db983463
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•