1178858 - Video would not playback after seek seekbar first if media.autoplay.enabled = false

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Alice0775 White]

+++ This bug was initially created as a clone of Bug #1173844  +++

See Bug #1173848 Comment 2

It's even worse if you decide to seek first. Then the button will be stuck showing pause and clicking it arbitrary times won't have any effect whatsoever. Playback only starts if you change resolutions in the player. I think it's a serious breakage.

Steps To Reproduce:
1. Make sure media.autoplay.enabled = false in about:config
2. Open any video
   (e.g. http://www.youtube.com/watch?v=BH0BNbwqNK8 )
3. Seek seekbar first
4. Attempt to play back

Actual Results:
Not start


Expected Results:
Video should playback properly


Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3ba889bb0741&tochange=e637319144d3

Suspect : Bug 659285

Comment 1

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1178858-Video-would-not-playback-after-seek-seekbar-first-if-media.autoplay.enabled-false-15072415-279994a.patch

Comment 2

[Randall Barker [:rbarker]]

Comment on attachment 8638825 [details] [diff] [review]
0001-Bug-1178858-Video-would-not-playback-after-seek-seekbar-first-if-media.autoplay.enabled-false-15072415-279994a.patch

This patch tries to detect when the user interacts with the scrubber so that the script can start playing when the video is ready. I removed the previous play detection since it seemed redundant.

Comment 3

[Randall Barker [:rbarker]]

Will need to be uplifted to 41.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please provide a Try link.

Comment 5

[Randall Barker [:rbarker]]

Sorry:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3cafbcf6ec9

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f9f3575ce49

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5f9f3575ce49

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Randall, do you want to request uplift of this patch to Aurora? Given that this has been in m-c for a few day I am assuming it must be a safe patch. What do you think?

Comment 9

[Randall Barker [:rbarker]]

Comment on attachment 8638825 [details] [diff] [review]
0001-Bug-1178858-Video-would-not-playback-after-seek-seekbar-first-if-media.autoplay.enabled-false-15072415-279994a.patch

Approval Request Comment
[Feature/regressing bug #]: Broke seek bar when pref media.autoplay.enabled was set to false.
[User impact if declined]: Seek bar will not work on sites like youtube when pref is set to false.
[Describe test coverage new/current, TreeHerder]: There are not tests for this pref
[Risks and why]: On desktop, this pref is only accessible via about:config. There is a check box on fennec.
[String/UUID change made/needed]: None

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8638825 [details] [diff] [review]
0001-Bug-1178858-Video-would-not-playback-after-seek-seekbar-first-if-media.autoplay.enabled-false-15072415-279994a.patch

Let's uplift to Aurora given that this has been in m-c for a few days.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Alice, could you please verify this issue is fixed on a 07/28 or later Nightly build? Thanks!

Comment 12

[Alice0775 White]

I cannot reproduce the problem on latest Nightly42.0a1.

https://hg.mozilla.org/mozilla-central/rev/f3b757156f69
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 ID:20150805030208

Comment 13

[Carsten Book [:Tomcat]]

needs rebase for mozilla-aurora

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/afe99b047762