117887 - elements inherit specified positioning property values instead of computed values (computed style)

Status: RESOLVED INVALID

(Core :: Layout: Positioned, defect)

Description

[tfriesen]

According to the CSS2 specs,elements should inherit computed values.
In the test case below,the positioned DIVs seem to inherit the
specified left and top property values from the A.
The A is not positioned,so the it should not have computed values for left and 
top.
So the DIVs should fall back on the initial values which is "auto".

For reference see:
http://www.w3.org/TR/REC-CSS2/cascade.html#value-def-inherit

Comment 1

[tfriesen]

Attachment: test case

Comment 2

[tfriesen]

maybe this is more a styling problem

Comment 3

[Richard Brodie]

Mozilla's behaviour looks correct to me. The way I read the specification, the 
computed value is merely the specified value converted to absolute units, so 
the same in this case. I don't see that the left and top properties don't apply 
to the non-positioned bloack affects this.

http://www.w3.org/TR/REC-CSS2/cascade.html#computed-value

Comment 4

[Boris Zbarsky [:bzbarsky]]

Inheritance is style system.  Are the divs _really_ inheriting the specified 
value?  The testcase given does not actually test that...

To really test that:

1)  Put the <a> inside an absolutely positioned div with nonzero (preferably
    large) padding.
2)  Make the specified value a percentage value, not a pixel value (otherwise
    there is no difference between computed and specified value)
3)  See whether the offsets of the two divs take the padding into account when
    converting the percentage to pixels.

Not confirming, since I have no Mozilla to test with at the moment....

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The spec doesn't really define what the computed values are for elements to
which the property doesn't apply, I don't think.  Or does it?

Comment 6

[tfriesen]

What would be the point of having computed values in this case?
At least in the context of CSS
If CSS is not doing the positioning,what would it use 
for a reference for these values?
It has the values in the style sheet,but those values are a tad misleading.

Comment 7

[tfriesen]

Perhaps my perception of computed values is a bit off.
I would have thought that to get a computed value,all
related properties would need to be taken into account.
So the value of the position property would be considered
when computing values for left and top.
If a computed value is just a converted specified value,then this
bug is probably invalid.
This bug report is not well defined so invaliding may not be
a bad idea in any case. 

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: testcase

This testcase tests inheritance of percent offsets from statically positioned
elements (Pixel offsets are just inherited).  It seems that relatively
positioned elements don't inherit anything useful (the computed value is 0)
whereas absolutely positioned elements inherit the offsets of their first
absolutely positioned ancestor (instead of inheriting from the statically
positioned parent).

Comment 9

[Boris Zbarsky [:bzbarsky]]

So the point is that the computed value is not in fact what is inherited, since
the element the value is computed for is not the element inherited from in the
percentage case.  There is no way to make computed style do this right....

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

->Layout, since almost all of the necessary changes go in Layout (although the
style system might need to use an explicit inherit value in the style struct if
it isn't already).  We might want to discuss this in the CSS WG since this is
hard to implement, though.

Comment 11

[Boris Zbarsky [:bzbarsky]]

This is definitely something the WG should talk about.  If a clarification of
what computed position values should be for static elements results, that would
be wonderful.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Setting qa to Ian with the hope of bringing more WG attention to this... ;)

Comment 13

[Hixie (not reading bugmail)]

As of recently it was decided that computed values should be layout independent.

Thus, in:

  margin: 59%;

...the computed value of 'margin-top' is '59%', and it is that that is inherited.
Note that this means our hard work for 'text-indent' has to be changed back. :-)

The next CSS2.1 draft should show this in the computed value lines.

Comment 14

[Boris Zbarsky [:bzbarsky]]

How does that affect GetComputedStyle?  If that needs changing, file a bug?

Comment 15

[Hixie (not reading bugmail)]

It will need changing too. (I told you we should have a single way of getting
computed style... :-P) I don't want to file any bugs until CSS2.1 is in CR.

Comment 16

[Hixie (not reading bugmail)]

We render the test case correctly now but the values returned in the DOM are no 
longer the computed values, they are the actual values (I think). Maybe this bug 
should be dependent on a new bug to make getComputedStyle() use the new 
definition of "computed".

Comment 17

[Boris Zbarsky [:bzbarsky]]

Sure thing.  Note that changing the behavior of getComputedStyle for positioning
properties is likely to break many pages, so it's something to be done VERY
carefully, and after consultation with the evang folks.

Comment 18

[Boris Zbarsky [:bzbarsky]]

Actually, why is this not invalid at this point?  We should be rendering the way
we are rendering and the getComputedStyle issue is covered by bug 227280

Comment 19

[Hixie (not reading bugmail)]

fair enough