Closed Bug 1178893 Opened 5 years ago Closed 4 years ago

WebGL conformance test conformance/state/gl-enum-tests fails (independent of hardware)

Categories

(Core :: Canvas: WebGL, defect)

41 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jujjyl, Assigned: liammiddlebrook)

Details

(Keywords: foxfood, Whiteboard: [gfx-noted])

Attachments

(1 file)

STR: Visit https://www.khronos.org/registry/webgl/sdk/tests/conformance/state/gl-enum-tests.html?webglVersion=1

Observed: The test reports an error:

FAIL getError expected: INVALID_ENUM. Was NO_ERROR : gl.getParameter(desktopGL['NUM_COMPRESSED_TEXTURE_FORMATS']) should return INVALID_ENUM.

Expected: The test should pass.

This was seen to fail on the following devices:
 - SPARK, GIADA, MACBOOK_AIR_OSX, MACBOOK_AIR_WIN, MACBOOK_PRO_OSX, MACBOOK_PRO_WIN, MACMINI, MACPRO, NEXUS-4, NEXUS-5, NEXUS-10, SURFACE, WINDBOX, HASWELL, HPOMEN

See https://bugzilla.mozilla.org/show_bug.cgi?id=1178601 for hardware configuration details of these systems.
Keywords: foxfood
Whiteboard: [gfx-noted]
QA Whiteboard: [foxfood-triage]
Here's a patch that worked for me to fix this bug. It looks like someone put an extra case in the switch statement inside of getParamater that wasn't needed.
Comment on attachment 8653021 [details] [diff] [review]
bug-1178893-fix.patch

Review of attachment 8653021 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, that looks correct.
Attachment #8653021 - Flags: review?(dglastonbury) → review+
Assignee: nobody → liammiddlebrook
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/143e3838bd2c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.