Closed Bug 1179122 Opened 5 years ago Closed 5 years ago

[e10s] TextComposition should manage target in parent process even when its child process has focus

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
e10s + ---
firefox42 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

(Keywords: inputmethod)

Attachments

(1 file)

Currently, EventStateManager sends composition events to TabParent. Therefore, TextComposition is now created only in the process which has composition actually.

But this causes a lot of bugs which are detected by |Assertion failure: aCompositionEvent->message == (2200)| since if TabParent becomes deactive during a composition, WidgetCompositionEvent is dispatched to different content in the parent.

For preventing this issue, TextComposition should guarantee that all composition events are sent to same TabParent.
Attached patch PatchSplinter Review
See comment 0 for the detail. Although, even with this patch, I sometimes see hitting the assertion. Sigh... (Of course, this actually fixes some cases of that, though.)
Attachment #8628577 - Flags: review?(bugs)
Attachment #8628577 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/6d96d03b8b20
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.