1179143 - Have a way to detect android_version for marionette-webapi tests

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

As [1], it's useful if there's a way to detect android_version in manifest of marionette-webapi tests

[1] https://dxr.mozilla.org/mozilla-central/source/dom/media/tests/mochitest/mochitest.ini#3

Comment 1

[Andreas Tolfsen ❲:ato❳]

This feels like something it would make sense to return as part of the capabilities when you start a new session.

Comment 2

[Edgar Chen [:edgar]]

mochitest [1] and xpcshell [2] supports detecting android_version in manifest, maybe marionette-webapi tests can use the same way (I am not sure).

[1] https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsremote.py#493-499
[2] https://dxr.mozilla.org/mozilla-central/source/testing/xpcshell/remotexpcshelltests.py#215-218

Comment 3

[Andreas Tolfsen ❲:ato❳]

(In reply to Edgar Chen [:edgar][:echen] from comment #2)
> mochitest [1] and xpcshell [2] supports detecting android_version in
> manifest, maybe marionette-webapi tests can use the same way (I am not sure).

Okay, so you can already sort of do that through calling executeScript with something like `return runEmulatorCmd(["getprop", "ro.build.version.sdk"])` I should think.

Comment 4

[John Dai[:jdai]]

Attachment: Part 1: Detect android_version for marionette-webapi tests.

It works on my local machine. Due to bug 1188330, I will provide a try link when TC marionette-webapi fixed.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to John Dai[:johnz][:jdai] from comment #4)
> Created attachment 8653296 [details] [diff] [review]
> Detect android_version for marionette-webapi tests.
> 
> It works on my local machine. Due to bug 1188330, I will provide a try link
> when TC marionette-webapi fixed.

(Y)

Comment 6

[John Dai[:jdai]]

Attachment: Part 2: Update testcase to apply android_version filter.

Comment 7

[John Dai[:jdai]]

Try link:
https://treeherder.allizom.org/#/jobs?repo=try&revision=0b3a5d97b724

Comment 8

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8653296 [details] [diff] [review]
Part 1: Detect android_version for marionette-webapi tests.

Review of attachment 8653296 [details] [diff] [review]:
-----------------------------------------------------------------

Looks mostly good to me.  Although please consider using MozReview next time.

::: testing/marionette/client/marionette/runner/base.py
@@ +795,5 @@
> +            # can be conditional on android_version.
> +            androidVersion = dm.shellCheckOutput(['getprop', 'ro.build.version.sdk'])
> +            self.logger.info(
> +                "Android sdk version '%s'; will use this to filter manifests" %
> +                str(androidVersion))

Coercing to string is implicit

Comment 9

[Edgar Chen [:edgar]]

Comment on attachment 8653390 [details] [diff] [review]
Part 2: Update testcase to apply android_version filter.

Review of attachment 8653390 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thank you.

Comment 10

[John Dai[:jdai]]

(In reply to Andreas Tolfsen (:ato) from comment #8)
> Comment on attachment 8653296 [details] [diff] [review]
> Part 1: Detect android_version for marionette-webapi tests.
> 
> Review of attachment 8653296 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks mostly good to me.  Although please consider using MozReview next time.
> 

Okay, I will, thanks for the review.

> ::: testing/marionette/client/marionette/runner/base.py
> @@ +795,5 @@
> > +            # can be conditional on android_version.
> > +            androidVersion = dm.shellCheckOutput(['getprop', 'ro.build.version.sdk'])
> > +            self.logger.info(
> > +                "Android sdk version '%s'; will use this to filter manifests" %
> > +                str(androidVersion))
> 
> Coercing to string is implicit

Will do.

Comment 11

[John Dai[:jdai]]

Attachment: Part 1: Detect android_version for marionette-webapi tests. r=ato

Comment 12

[John Dai[:jdai]]

Attachment: Part 2: Update testcase to apply android_version filter. r=echen

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/298d7dcbda70
https://hg.mozilla.org/integration/mozilla-inbound/rev/08960e6b65c3

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/298d7dcbda70
https://hg.mozilla.org/mozilla-central/rev/08960e6b65c3