1179162 - [FLAME-L][Video] When opening Video app, the video crashes

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Hermes Cheng (inactive after July 27, 2015)]

+++ This bug was initially created as a clone of Bug #1171836 +++

### STR
1. Open Video App

### Actual
Video app crashes and even adb logcat is terminated...

### Expected
Video app open correctly

### Crash Report
https://crash-stats.mozilla.com/report/index/249a2e5b-b420-4f00-9ca6-7e57a2150701

### Version
Local build

Build ID               20150630184049
Gaia Revision          5997b406e77ea726fbd9047057a1c3504f6cd6d4
Gaia Date              2015-06-30 01:48:01
Gecko Revision         n/a
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      5.0
Firmware(Incremental)  eng.hermesc.20150630.182707
Firmware Date          二  6月 30 18:27:28 CST 2015
Bootloader             L1TC00011L60

Comment 3

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Attachment: cherry pick QCT patch for YUV Venus format color convertor

Comment 4

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8631480 [details] [review]
cherry pick QCT patch for YUV Venus format color convertor

Looks good!

FYI, but there are more preferred way to this problem from gecko point of view. It is Bug 1120780 and gralloc hal's fix. Actual change is the below.
 > https://github.com/mozilla-b2g/hardware_qcom_display/commit/7c83e14bfad823c66d643bf4e81b862ad22eab7b

It is used by nexus-5-l, it fixed the problem almost all cases, but it caused the regression( bug 1147763). The regression is caused by POVB problem :-( flame-kk already use the color convertor side fix and Bug 1120780 fix has a regression risk. Therefore, the color convertor side fix is OK for now.

Comment 5

[Sotaro Ikeda [:sotaro]]

https://github.com/mozilla-b2g/platform_frameworks_av/commit/c37d7946d07f21b14549c59b37a87ed6f3860829

Comment 6

[Carsten Book [:Tomcat]]

seems sotaro did this already the checkin, is there more to do here ?

Comment 7

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Yes, Sotaro has finished merging the patch.