1179174 - [Notifications] After restarting the device, user can't open the received file via Bluetooth at Notification.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[SandKing]

Attachment: Bug log: 2104.3GP

[1.Description]:
[Flame v2.2&master][Nexus5 v2.2&master][Notifications]After restarting the device, tap the file received prompt in Notification, but user fails to open the file.
See log:"logcat_2104.txt"
See video:2104.3GP
Found Time:21:04

[2.Testing Steps]: 
1. Receive some files by Bluetooth.
2. After finished, you can see the notification info, then restart device.
3. After device restarts, tap the transfer notification. 

[3.Expected Result]: 
3. User can open the the transfered file.

[4.Actual Result]: 
3. The file can not be opened.

[5.Reproduction build]: 
Device: Flame v2.2 (Affected) 
Build ID               20150630162500
Gaia Revision          bd386f346eb1591fddbc84bf034b22700e7e2a58
Gaia Date              2015-06-30 15:53:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f16c1125b9d6
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150630.200238
Firmware Date          Tue Jun 30 20:02:49 EDT 2015
Bootloader             L1TC000118D0

Device: Flame master (Affected)
Build ID               20150630160220
Gaia Revision          5997b406e77ea726fbd9047057a1c3504f6cd6d4
Gaia Date              2015-06-30 01:48:01
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/291614a686f1
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150630.193722
Firmware Date          Tue Jun 30 19:37:34 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v2.2 (Affected) 
Build ID               20150630162500
Gaia Revision          bd386f346eb1591fddbc84bf034b22700e7e2a58
Gaia Date              2015-06-30 15:53:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f16c1125b9d6
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150630.200214
Firmware Date          Tue Jun 30 20:02:30 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 master (Affected)
Build ID               20150630010206
Gaia Revision          27fe0f4261e3685187769411f2f74cff19287b19
Gaia Date              2015-06-29 14:29:00
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/aad95360a002
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150630.042823
Firmware Date          Tue Jun 30 04:28:43 EDT 2015
Bootloader             HHZ12f


[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free test

Comment 1

[SandKing]

Attachment: Bug log: logcat_2104.txt

Comment 2

[Hermes Cheng (inactive after July 27, 2015)]

Kevin, could you take a look?

Comment 3

[Kevin Grandon :kgrandon]

I probably won't be able to get to this any time soon, but go ahead and request the appropriate blocking status and the team will triage it.

Comment 4

[Hermes Cheng (inactive after July 27, 2015)]

[Blocking Requested - why for this release]:

not friendly for user

Comment 5

[Ben Tian (inactive)]

Please attached correct symptom video. The comment 0 file is the same log file as comment 1.

Comment 6

[Ben Tian (inactive)]

ni? gaia dev Fred.

Fred, can you confirm whether gaia keeps the notification link to received file after device restarts?

Comment 7

[[e-mail]]

The notification link seems the same. The only difference is the path of icon_bluetooth.png, but I think its not related to this issue. Will investigate further on this issue.

File 1

<div data-manifest-u-r-l="app://system.gaiamobile.org/manifest.webapp" data-type="desktop-notification" data-obsolete-a-p-i="false" data-predefined-dir="ltr" data-no-clear="false" data-notification-id="app://system.gaiamobile.org/manifest.webapp#notag:{d39e5a81-da78-4c0b-95e3-3b414a0cdef6}" role="link" class="notification" lang="zh-TW"><img role="presentation" src="app://system.gaiamobile.org/style/bluetooth_transfer/images/icon_bluetooth.png"><div class="title-container"><div dir="auto" class="title">已接收檔案</div><span data-timestamp="Thu Jul 02 2015 11:48:59 GMT+0800 (UTC)" class="timestamp">1 分鐘前</span></div><div class="detail"><div dir="auto" class="detail-content">11227039_10200781416095144_6763953261762247832_n.jpg</div></div></div>

restart

<div data-manifest-u-r-l="app://system.gaiamobile.org/manifest.webapp" data-type="desktop-notification" data-obsolete-a-p-i="false" data-predefined-dir="ltr" data-no-clear="false" data-notification-id="app://system.gaiamobile.org/manifest.webapp#notag:{d39e5a81-da78-4c0b-95e3-3b414a0cdef6}" role="link" class="notification" lang="zh-TW"><img role="presentation" src="style/bluetooth_transfer/images/icon_bluetooth.png"><div class="title-container"><div dir="auto" class="title">已接收檔案</div><span data-timestamp="Thu Jul 02 2015 11:48:59 GMT+0800 (UTC)" class="timestamp">3 分鐘前</span></div><div class="detail"><div dir="auto" class="detail-content">11227039_10200781416095144_6763953261762247832_n.jpg</div></div></div>

File 2

<div data-manifest-u-r-l="app://system.gaiamobile.org/manifest.webapp" data-type="desktop-notification" data-obsolete-a-p-i="false" data-predefined-dir="ltr" data-no-clear="false" data-notification-id="app://system.gaiamobile.org/manifest.webapp#notag:{49beb8b6-df64-464a-af19-d66e8fc37252}" role="link" class="notification" lang="zh-TW"><img role="presentation" src="app://system.gaiamobile.org/style/bluetooth_transfer/images/icon_bluetooth.png"><div class="title-container"><div dir="auto" class="title">已接收檔案</div><span data-timestamp="Thu Jul 02 2015 11:57:36 GMT+0800 (UTC)" class="timestamp">剛剛</span></div><div class="detail"><div dir="auto" class="detail-content">11400985_10200781437735685_4366208100966832212_n.jpg</div></div></div>


restart

<div data-manifest-u-r-l="app://system.gaiamobile.org/manifest.webapp" data-type="desktop-notification" data-obsolete-a-p-i="false" data-predefined-dir="ltr" data-no-clear="false" data-notification-id="app://system.gaiamobile.org/manifest.webapp#notag:{49beb8b6-df64-464a-af19-d66e8fc37252}" role="link" class="notification" lang="zh-TW"><img role="presentation" src="style/bluetooth_transfer/images/icon_bluetooth.png"><div class="title-container"><div dir="auto" class="title">已接收檔案</div><span data-timestamp="Thu Jul 02 2015 11:57:36 GMT+0800 (UTC)" class="timestamp">1 分鐘前</span></div><div class="detail"><div dir="auto" class="detail-content">11400985_10200781437735685_4366208100966832212_n.jpg</div></div></div>

Comment 8

[Ben Tian (inactive)]

Set component to Gaia::System::Notification accordingly.

Comment 9

[SandKing]

Attachment: Bug video: 2104.3GP

Add bug video.

Comment 10

[[e-mail]]

Confirm gaia did not keep the notification link but just ask gecko to resend the notification.

Once `notifications.resend` key is set(can be config in settings>notification), gaia will ask gecko to resend the notification after reboot.

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/notification_screen.js#L818

Comment 11

[Ben Tian (inactive)]

Fred, what's your question for ni? me?

(In reply to Fred Lin [:gasolin] from comment #10)
> Confirm gaia did not keep the notification link but just ask gecko to resend
> the notification.
> 
> Once `notifications.resend` key is set(can be config in
> settings>notification), gaia will ask gecko to resend the notification after
> reboot.
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/
> notification_screen.js#L818

Comment 12

[[e-mail]]

Since gaia just ask gecko to resend the notification when restarted, 
we need check whats different on gecko side.

Comment 13

[Ben Tian (inactive)]

It's weird. I thought system app remembers notification data once it receives them, instead of relying on gecko components to keep them. Can you detail the mechanism that notification works?

Comment 14

[Ben Tian (inactive)]

qawanted to test whether this bug happens on v2.1.

I doubt this bug results from bug 1103560 that refactors notification system message, and system app BT [1] doesn't follow the wrapping method as [2].

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/bluetooth_transfer.js#L476
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/notifications_system_message.js#L23

Comment 15

[[e-mail]]

In master version, system did not remember the notification data. System will send `desktop-notification-resend` event when reboot. And gecko is responsible to resend all notifications.

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/notification_screen.js#L818

Comment 16

[Ben Tian (inactive)]

(In reply to Fred Lin [:gasolin] from comment #15)
> In master version, system did not remember the notification data. System
> will send `desktop-notification-resend` event when reboot. And gecko is
> responsible to resend all notifications.
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/
> notification_screen.js#L818

By 'gecko' I think you mean other gecko component rather than gecko bluetooth? The code doesn't seem to relate to gecko bluetooth.

Comment 17

[SandKing]

Attachment: Bug log: logcat_0532.txt

Hi Ben,
We get different phenomenon on v2.1., When we restart the device, the buletooth notification will disappear on Flame 2.1
See video:0532.3GP
See log:logcat_0532.txt

Flame 2.1(Affected):
Build ID               20150705001204
Gaia Revision          d13826b20b4a45e3f5cd4b25a30a737d8be7f1b9
Gaia Date              2015-07-02 23:36:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/37de99064c33
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150705.040344
Firmware Date          Sun Jul  5 04:03:55 EDT 2015
Bootloader             L1TC000118D0

Comment 18

[SandKing]

Attachment: Bug video: 0532.3GP

Comment 19

[SandKing]

v2.1S have same phenomenon with v2.1, so add the "Tracking Flags"

v2.1s affected:
Build ID               20150705001205
Gaia Revision          c1a9fe0710a214df0dcabe89e45f3a9c41c282f9
Gaia Date              2015-07-03 02:24:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/e6b6832ba6d4
Gecko Version          34.0
Device Name            scx15_sp7715ea
Firmware(Release)      4.4.2
Firmware(Incremental)  145
Firmware Date          Thu Apr 16 22:58:57 CST 2015

Comment 20

[[e-mail], [e-mail]]

I get some log while I'm able to reproduce the issue(click on the notification).

==================== log ==================== 
W/GeckoConsole(  196): Content JS WARN: No data payload considering legacy and force-closing. 
W/GeckoConsole(  196):     at .processSystemMessage (app://system.gaiamobile.org/js/notifications_system_message.js:74:9)
W/GeckoConsole(  196): Content JS WARN: Found a match for "File received": "IMG_1953.JPG". Will force-close this. 
W/GeckoConsole(  196):     at .closeOldNotification/</< (app://system.gaiamobile.org/js/notifications_system_message.js:153:1)
E/sdcard  (  205): missing packages.list; retrying
E/sdcard  (  205): missing packages.list; retrying


It means that the |message.data| is false[1]. In other words, we might miss the notification data after reboot the device.
[1]: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/notifications_system_message.js#L73-L77

Comment 21

[[e-mail]]

As comment 14, confirm after reboot, bluetooth_transfer could get click event on handleSystemMessageNotification method after follow the special system message format.

It means some rewrite of bluetooth_transfer is needed to make notification works after reboot.

Comment 22

[:gerard-majax]

(In reply to Ian Liu [:ianliu] from comment #20)
> I get some log while I'm able to reproduce the issue(click on the
> notification).
> 
> ==================== log ==================== 
> W/GeckoConsole(  196): Content JS WARN: No data payload considering legacy
> and force-closing. 
> W/GeckoConsole(  196):     at .processSystemMessage
> (app://system.gaiamobile.org/js/notifications_system_message.js:74:9)
> W/GeckoConsole(  196): Content JS WARN: Found a match for "File received":
> "IMG_1953.JPG". Will force-close this. 
> W/GeckoConsole(  196):     at .closeOldNotification/</<
> (app://system.gaiamobile.org/js/notifications_system_message.js:153:1)
> E/sdcard  (  205): missing packages.list; retrying
> E/sdcard  (  205): missing packages.list; retrying
> 
> 
> It means that the |message.data| is false[1]. In other words, we might miss
> the notification data after reboot the device.
> [1]:
> https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/
> notifications_system_message.js#L73-L77

Yes. It means the notification was not sent with the proper data, and there is nothing we can do.

Comment 23

[:gerard-majax]

Please check bug 1103560.

Comment 24

[:gerard-majax]

For screenshot, for example, we set it there:
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/screenshot.js#L256

I see that https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/bluetooth_transfer.js does call NotificationHelper.send(), this is probably what you want to fix. Please note that bug 1103560 has been only uplifted to 2.2. I doubt it can make it easily to 2.1s.

Comment 25

[Ben Tian (inactive)]

SnadKing,

Got it. Thanks.

(In reply to SandKing from comment #17)
> Created attachment 8629797 [details]
> Bug log: logcat_0532.txt
> 
> Hi Ben,
> We get different phenomenon on v2.1., When we restart the device, the
> buletooth notification will disappear on Flame 2.1
> See video:0532.3GP
> See log:logcat_0532.txt
> 
> Flame 2.1(Affected):
> Build ID               20150705001204
> Gaia Revision          d13826b20b4a45e3f5cd4b25a30a737d8be7f1b9
> Gaia Date              2015-07-02 23:36:46
> Gecko Revision        
> https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/37de99064c33
> Gecko Version          34.0
> Device Name            flame
> Firmware(Release)      4.4.2
> Firmware(Incremental)  eng.cltbld.20150705.040344
> Firmware Date          Sun Jul  5 04:03:55 EDT 2015
> Bootloader             L1TC000118D0

Comment 26

[[e-mail]]

Attachment: pull request redirect to github

I've test with single/multiple files transfer with BT, and click notification to image preview now works fine after reboot.

I'll add related tests before send review.

Comment 27

[[e-mail], [e-mail]]

Comment on attachment 8630875 [details] [review]
pull request redirect to github

Hi Fred,

Thanks for your help here. I leave some comment/nits on GitHub. It's better to access the meta data in the same place. Besides of this point, feedback+ with me.

Comment 28

[[e-mail]]

Comment on attachment 8630875 [details] [review]
pull request redirect to github

issue addressed, works on real device, related test green on treeherder.

Add lissyx in to make sure handleSystemMessageNotification related usage is right

Comment 29

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8630875 [details] [review]
pull request redirect to github

Ian can review this.

Comment 30

[:gerard-majax]

Comment on attachment 8630875 [details] [review]
pull request redirect to github

That looks good to me for the system message notification part.

Comment 31

[[e-mail], [e-mail]]

Comment on attachment 8630875 [details] [review]
pull request redirect to github

Good works here! r+ with my manual test successfully.

Comment 32

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/e2e8c27f27b1600a76b6f41b3fa910e25740f40e

thanks!

Comment 33

[SandKing]

This bug has been verified as pass on latest Nightly build of Flame master and Nexus5 master.
STR:
Same STR as comment0

Actual results: The transfered file can be open
Reproduce rate: 0/5

Device: Flame master build(Pass)
Build ID               20150709160207
Gaia Revision          bdddfe1ebb796e2bc1c048d5c4e0f97f3d06f98b
Gaia Date              2015-07-09 11:58:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/adfdc7f29ba7
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150709.193215
Firmware Date          Thu Jul  9 19:32:27 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus5 master build(Pass):
Build ID               20150709160207
Gaia Revision          bdddfe1ebb796e2bc1c048d5c4e0f97f3d06f98b
Gaia Date              2015-07-09 11:58:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/adfdc7f29ba7
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150709.191337
Firmware Date          Thu Jul  9 19:13:55 EDT 2015
Bootloader             HHZ12f