Shouldn't offer reader mode for crash-reports.mozilla.com

NEW
Unassigned

Status

()

Toolkit
Reader Mode
P5
normal
3 years ago
2 years ago

People

(Reporter: Vasilica Mihasca, QA [away for an extended period of time - please needinfo addonsqa@softvision.ro], Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(firefox42 affected)

Details

(Whiteboard: [reader-mode-readability-algorithm][reader-mode-isreadable-detection])

Reproducible on: Firefox 38.0.5, Firefox 39 RC,Firefox 40.0a2 and Firefox 42.0a1 on Windows 8.1 32-bit

STR
1.Launch Firefox.
2.Navigate to https://crash-stats.mozilla.com/report/index/3078c479-b673-47d9-96a2-f891c2150701 (Crash Reports page)
3.Click on “Reader view” button from location bar.

ER
The page is correctly displayed in Reader View Mode.

AR
A piece of code is displayed instead of the text.

Additional notes:
- This issue is reproducible on Firefox 38.0.5 (20150525141253), Firefox 39 RC build 6 (20150630154324), 40.0a2 (2015-06-29) and Firefox 42.0a1 (2015-06-30) under Windows 8.1 32-bit.
- I am attaching a screenshot: http://i.imgur.com/5fANI5t.jpg

Comment 1

3 years ago
I don't think this is a bug. This is in fact the content of the page in the "raw dump" tab.

Since this is a multi-tab app style page, I don't think offering reader view for it makes a lot of sense. Perhaps the bug here is that we're offering reader view at all? Who is responsible for making that decision?
Status: NEW → UNCONFIRMED
Ever confirmed: false
Flags: needinfo?(margaret.leibovic)

Comment 2

3 years ago
We use a very basic heuristic to determine whether or not to offer reader view:
https://github.com/mozilla/readability/blob/master/Readability.js#L1704

Because this function runs on every page load, we are very concerned about its performance impact, so it is challenging to try to make this perfect.

We could try to tweak the algorithm to account for this test case, but we would just also have to be careful to not regress other test cases. Filing an issue on the readability repo would probably be the best way forward here, although I don't think there's anyone actively burning down that issue list right now.
Flags: needinfo?(margaret.leibovic)

Comment 3

2 years ago
New testcase (for now): https://crash-stats.mozilla.com/report/index/b02e97f5-bccf-48ed-bfc1-705222160528
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P5
Summary: Mozilla Crash Reports Page incorrect displayed in Reader View Mode → Shouldn't offer reader mode for crash-reports.mozilla.com

Updated

2 years ago
Whiteboard: [reader-mode-readability-algorithm][reader-mode-isreadable-detection]
You need to log in before you can comment on or make changes to this bug.