Closed Bug 1179266 Opened 5 years ago Closed 1 year ago

[Tablet] Fix Android L "share" list item in long press context menu

Categories

(Firefox for Android :: General, defect, P3)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 69
Tracking Status
fennec + ---
firefox54 --- wontfix
firefox55 --- wontfix
firefox56 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- verified
firefox69 --- fixed

People

(Reporter: ioana.chiorean, Assigned: adam.orban)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [bcs:p2])

Attachments

(5 files, 1 obsolete file)

Attached image Screenshot
Bug 1132747 fixed only the mobile side.

Steps:
- Open context menu on several links ( preferably without having any quick search options set) 

Expected results:
-the options should be aligned  

Actual results:
- Share option sis more on the left side
Flags: needinfo?(michael.l.comella)
ni on Martyn as I hears mcomella is in PTO
Flags: needinfo?(mhaigh)
Yuck that is one sloppy looking menu.
tracking-fennec: --- → ?
Ioana, what device are you using? I can't repro on my N9 running Lollipop.
Flags: needinfo?(michael.l.comella) → needinfo?(ioana.chiorean)
Assignee: nobody → michael.l.comella
Nexus 7 - all branches Nightly 42.0a1 , Aurora 41.0a2, Beta/RC 39
Flags: needinfo?(ioana.chiorean)
tracking-fennec: ? → +
I'm not going to get to this anytime soon.
Assignee: michael.l.comella → nobody
tracking-fennec: + → ?
tracking-fennec: ? → +
Keywords: good-first-bug
Priority: -- → P3
[triage@0719] good 1st bug. + w/ P3
Attached image Share Link 2.png
This also happens when accessing the Share Link context menu and the Share Video menu. Some icons have a different size in the context menu. Added new attachment with a snapshot of it.
Version: unspecified → Trunk
I can confirm the different icon sizes on Android Oreo 8.1 when sharinga link.
Maybe Firefox should use the system default share chooser dialog for sharing links like most other apps do?
Duplicate of this bug: 1510891

It seems to be fixed in Firefox 66.
The share menu looks good now on Oreo here. All icons are displayed in the same size.

Thanks for the fix!

Assignee: nobody → adam.orban
Status: NEW → ASSIGNED
Keywords: checkin-needed

Adam, could you take a look over this? Lando complains about one of these:

Lando says "This diff does not have the proper author information uploaded to Phabricator", but I see an author on Phabricator. What's wrong?

There are a few reasons this could happen:

The revision was created via the Phabricator Web UI or via an unsupported client.
    Use arcanist or moz-phab to submit the patch instead; see the Mozilla Phabricator User Guide for help.

The revision was created via arcanist or moz-phab, but the error still appears.
    This can happen if you have not set an author email in your .hgrc file (or git config). Set your author email in your .hgrc to your username, Firstname Lastname <yourldapemail@mozilla.com>. Update your commit so it contains the new author data. Re-run moz-phab submit or arc diff so that the new commit+data is uploaded to Phabricator.
Flags: needinfo?(adam.orban)
Keywords: checkin-needed
Attachment #9063976 - Attachment is obsolete: true
Flags: needinfo?(adam.orban)
Keywords: checkin-needed

Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a49d2484923
[Tablet] Fix Android L "share" list item in long press context menu; r=petru

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Flags: qe-verify+

Re-opened in the latest Beta version 68.0b3.
Note that I was able to reproduce this issue on the context menu.
But as discussed on the above comments regarding Share Link context menu like Comment 8 the issue cannot be reproduced in that menu.
I was able to reproduce this issue using: Lenovo TB3 (Android 6.0).
And I couldn't reproduce the issue using: Xiaomi Mi Pad 2 (Android 5.1).
For more details please see the picture.

Thanks,
Andrei

Status: RESOLVED → REOPENED
Flags: qe-verify+
Resolution: FIXED → ---
Flags: qe-verify+
Flags: needinfo?(adam.orban)
Flags: needinfo?(adam.orban)
Keywords: checkin-needed

Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/808ad8234b40
[Tablet] Fix Android L "share" list item in long press context menu; r=petru

Keywords: checkin-needed
Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Target Milestone: Firefox 68 → Firefox 69

Adam, can you please request uplift of your patches to Fennec 68 Beta? We'll be supporting Fennec 68 in ESR until mid-2020 so it would be nice to have your fix.

Whiteboard: [bcs:p2]

Comment on attachment 9065311 [details]
Bug 1179266 - [Tablet] Fix Android L "share" list item in long press context menu; r?petru

Beta/Release Uplift Approval Request

  • User impact if declined: Small visual issue in that the share options are not properly aligned
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Open context menu on several links ( preferably without having any quick search options set)
    check the visual alignment
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small targeted code change
  • String changes made/needed:
Attachment #9065311 - Flags: approval-mozilla-beta?
Attachment #9067681 - Flags: approval-mozilla-beta?
QA Whiteboard: [qa-triaged]

Comment on attachment 9065311 [details]
Bug 1179266 - [Tablet] Fix Android L "share" list item in long press context menu; r?petru

fennec fix for 68.0b7

Attachment #9065311 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9067681 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9065311 [details]
Bug 1179266 - [Tablet] Fix Android L "share" list item in long press context menu; r?petru

actually this first patch is already on 68.

Attachment #9065311 - Flags: approval-mozilla-beta+

Verified as fixed in the latest nightly build 68.0a1 with Lenovo TB3 (Android 6.0).
Tomorrow I will verify this issue on the beta and mark the bug as verified if everything will be fine.

Flags: needinfo?(andrei.bodea)

Verified as fixed in the latest beta build 68.0b7 with Lenovo TB3 (Android 6.0).

Flags: needinfo?(andrei.bodea)
Flags: qe-verify+

Verified on Firefox Nightly 68.0a1(2019-06-03) with device Lenovo TB3 (Android 6.0) with status fixed.
Ticket will be marked as Verified - Fixed.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.