1179266 - [Tablet] Fix Android L "share" list item in long press context menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Ioana Chiorean]

Attachment: Screenshot

Bug 1132747 fixed only the mobile side.

Steps:
- Open context menu on several links ( preferably without having any quick search options set) 

Expected results:
-the options should be aligned  

Actual results:
- Share option sis more on the left side

Comment 1

[Ioana Chiorean]

ni on Martyn as I hears mcomella is in PTO

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Yuck that is one sloppy looking menu.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Ioana, what device are you using? I can't repro on my N9 running Lollipop.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Note that bug 1132747 is in 38.

Comment 5

[Ioana Chiorean]

Nexus 7 - all branches Nightly 42.0a1 , Aurora 41.0a2, Beta/RC 39

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I'm not going to get to this anytime soon.

Comment 7

[Wesly Huang (EPM)]

[triage@0719] good 1st bug. + w/ P3

Comment 8

[Levente Sacal]

Attachment: Share Link 2.png

This also happens when accessing the Share Link context menu and the Share Video menu. Some icons have a different size in the context menu. Added new attachment with a snapshot of it.

Comment 9

[Ralf]

Attachment: Wrong icon sizes in share link popup

I can confirm the different icon sizes on Android Oreo 8.1 when sharinga link.
Maybe Firefox should use the system default share chooser dialog for sharing links like most other apps do?

Comment 11

[Ralf]

It seems to be fixed in Firefox 66.
The share menu looks good now on Oreo here. All icons are displayed in the same size.

Thanks for the fix!

Comment 12

[Adam Orban]

Attachment: Bug 1179266 - [Tablet] Fix Android L "share" list item in long press context menu; r?petru

Comment 13

[Cosmin Sabou [:CosminS]]

Adam, could you take a look over this? Lando complains about one of these:

Lando says "This diff does not have the proper author information uploaded to Phabricator", but I see an author on Phabricator. What's wrong?

There are a few reasons this could happen:

The revision was created via the Phabricator Web UI or via an unsupported client.
    Use arcanist or moz-phab to submit the patch instead; see the Mozilla Phabricator User Guide for help.

The revision was created via arcanist or moz-phab, but the error still appears.
    This can happen if you have not set an author email in your .hgrc file (or git config). Set your author email in your .hgrc to your username, Firstname Lastname <[e-mail]>. Update your commit so it contains the new author data. Re-run moz-phab submit or arc diff so that the new commit+data is uploaded to Phabricator.

Comment 14

[Adam Orban]

Attachment: Bug 1179266 - [Tablet] Fix Android L "share" list item in long press context menu; r?petru

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a49d2484923
[Tablet] Fix Android L "share" list item in long press context menu; r=petru

Comment 16

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4a49d2484923

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 18

[Andrei Bodea[:andrei]]

Re-opened in the latest Beta version 68.0b3.
Note that I was able to reproduce this issue on the context menu.
But as discussed on the above comments regarding Share Link context menu like Comment 8 the issue cannot be reproduced in that menu.
I was able to reproduce this issue using: Lenovo TB3 (Android 6.0).
And I couldn't reproduce the issue using: Xiaomi Mi Pad 2 (Android 5.1).
For more details please see the picture.

Thanks,
Andrei

Comment 19

[Julien Cristau [:jcristau]]

for comment 18

Comment 20

[Adam Orban]

Attachment: Bug 1179266 - [Tablet] Fix Android L "share" list item in long press context menu; r?petru

Fix padding for mdpi tablets

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/808ad8234b40
[Tablet] Fix Android L "share" list item in long press context menu; r=petru

Comment 22

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/808ad8234b40

Comment 23

[Chris Peterson [:cpeterson]]

Adam, can you please request uplift of your patches to Fennec 68 Beta? We'll be supporting Fennec 68 in ESR until mid-2020 so it would be nice to have your fix.

Comment 24

[Adam Orban]

Comment on attachment 9065311 [details]
Bug 1179266 - [Tablet] Fix Android L "share" list item in long press context menu; r?petru

Beta/Release Uplift Approval Request

• User impact if declined: Small visual issue in that the share options are not properly aligned
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open context menu on several links ( preferably without having any quick search options set)
  check the visual alignment
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small targeted code change
• String changes made/needed:

Comment 25

[Julien Cristau [:jcristau]]

Comment on attachment 9065311 [details]
Bug 1179266 - [Tablet] Fix Android L "share" list item in long press context menu; r?petru

fennec fix for 68.0b7

Comment 26

[Julien Cristau [:jcristau]]

Comment on attachment 9065311 [details]
Bug 1179266 - [Tablet] Fix Android L "share" list item in long press context menu; r?petru

actually this first patch is already on 68.

Comment 27

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8a7a40a3e59f

Comment 28

[Andrei Bodea[:andrei]]

Verified as fixed in the latest nightly build 68.0a1 with Lenovo TB3 (Android 6.0).
Tomorrow I will verify this issue on the beta and mark the bug as verified if everything will be fine.

Comment 29

[Andrei Bodea[:andrei]]

Verified as fixed in the latest beta build 68.0b7 with Lenovo TB3 (Android 6.0).

Comment 30

[Diana Rus]

Verified on Firefox Nightly 68.0a1(2019-06-03) with device Lenovo TB3 (Android 6.0) with status fixed.
Ticket will be marked as Verified - Fixed.