1179335 - synthesizeMouseScroll seems to be dead

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Tom Tromey :tromey]

EventUtils.js:synthesizeMouseScroll seems dead.

AFAICT, nothing calls it.  And, it calls:

    utils.sendMouseScrollEvent(type, left + aOffsetX, top + aOffsetY, button,
                               scrollFlags, aEvent.delta, modifiers);

... but this doesn't seem to be defined anywhere.


pokyo. git grep synthesizeMouseScroll
testing/marionette/EventUtils.js: *  synthesizeMouseScroll
testing/marionette/EventUtils.js:function synthesizeMouseScroll(aTarget, aOffsetX, aOffsetY, aEvent, aWindow)
pokyo. git grep -i sendMouseScrollEvent
testing/marionette/EventUtils.js:    utils.sendMouseScrollEvent(type, left + aOffsetX, top + aOffsetY, button,

Comment 1

[David Burns :automatedtester]

I am guessing we need to update to use https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIDOMWindowUtils#sendWheelEvent%28%29

Comment 2

[David Burns :automatedtester]

Attachment: Bug 1179335: Remove unused Marionette mouse scroll functions;

The underlying code that this method calls from nsIDOMWindowUtils
was removed and has not caused issues in here. This is dead code.

Review commit: https://reviewboard.mozilla.org/r/143828/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143828/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8872341 [details]
Bug 1179335: Remove unused Marionette mouse scroll functions;

https://reviewboard.mozilla.org/r/143828/#review147580

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b4e233d48c1
Remove unused Marionette mouse scroll functions; r=whimboo

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0b4e233d48c1