1179355 - Battery charge lightning bolt indicator is invisible on dark grey charged battery icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Sheeri Cabral [:sheeri]]

Battery charge lightning bolt indicator is invisible on dark grey charged battery icon

Comment 1

[:Atoll]

The battery icon is dark grey, which is confusing. And the lightning bolt is tiny and low-contrast against it. It looks like a defect in the battery icon unless I put the phone right up to my face and stare closely at it.

Comment 2

[Sheeri Cabral [:sheeri]]

Changing the contrast is one option. Another option is get rid of the lightning bolt and have people rely on the red/green charging dot in the upper left hand corner.

Comment 3

[:Atoll]

A bigger lightning bolt would also be fine, or color indication if that's desirable.

Comment 4

[Tiffanie Shakespeare [:tif]]

From UX triage: 

Passing NI to Eric to take a look at. Eric, you have to open up an app, like Browser, and you will see what they are talking about. This isn't an issue on homescreen or lockscreen.

Thanks for pinging the UX team!!

Comment 5

[Eric Pang [:epang] UX]

(In reply to Sheeri Cabral [:sheeri] from comment #2)
> Changing the contrast is one option. Another option is get rid of the
> lightning bolt and have people rely on the red/green charging dot in the
> upper left hand corner.

Hi Sheeri, thanks for bringing up the issue.  Can we try updating the lightening bolt to white for the battery icon when the dark grey is used?

Comment 6

[Alberto Pastor [:albertopq]]

I don't think we can do this through code. The icons are always the same [1], but we apply a filter depending on the theme of the app, so all the whites become greys, but the blacks remain the same.

One possible solution would be leaving the lightning bolt transparent in the battery icon (in the same way the roaming icon does). That way, we would see it grey over white icons, and white over grey icons. Eric, what do you think?

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/statusbar/images/icons%402.25x.png

Comment 7

[Eric Pang [:epang] UX]

Attachment: status_bar_sprite.zip

Hey Alberto, I've updated the sprites here. Thanks!

Comment 8

[Eric Pang [:epang] UX]

Attachment: status_bar_sprite.zip

Comment 9

[Eric Pang [:epang] UX]

Attachment: status_bar_sprite.zip

Hey Alberto, I've updated the status bar sprites so the lightening bolt is transparent. Thanks!

Comment 10

[Alberto Pastor [:albertopq]]

Sorry Eric, but I can't still see the lightning bolt icon. Is just removed in both attachments. Are you sure the files are right?

Comment 11

[Eric Pang [:epang] UX]

Attachment: status_bar_sprites_new

Hey Alberto, sorry I must have uploaded the wrong file.  This one should be right now.

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1179355-lightning-bolt > mozilla-b2g:master

Comment 13

[Alberto Pastor [:albertopq]]

Comment on attachment 8710504 [details] [review]
[gaia] albertopq:1179355-lightning-bolt > mozilla-b2g:master

Here some examples with the patch:

https://drive.google.com/a/mozilla.com/folderview?id=0ByGvk9QDMNxZNEU2LVVEWjBPNGM&usp=sharing

Eric, could you ui-r please?
Guillaume, quick r?

Thanks!

Comment 14

[Eric Pang [:epang] UX]

Comment on attachment 8710504 [details] [review]
[gaia] albertopq:1179355-lightning-bolt > mozilla-b2g:master

R+ thanks Alberto, looks good!

Comment 15

[Guillaume Marty [:gmarty]]

Comment on attachment 8710504 [details] [review]
[gaia] albertopq:1179355-lightning-bolt > mozilla-b2g:master

The sprites look good to me.

Comment 16

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/89602d6ae53ecf4129b35a84e49d25b9fd37bc39