Private browsing ToolbarProgressView too dark

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

unspecified
Firefox 42
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 unaffected, firefox42 verified, fennec42+)

Details

Attachments

(3 attachments)

Posted image Screenshot
It should be private_browsing_purple - it uses that color in the color filter in code, but I'm not sure why it's not working.

Implemented in bug 864958.
Track 41 to follow bug 864958 please.
Assignee: nobody → michael.l.comella
tracking-fennec: --- → ?
Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh
Attachment #8628480 - Flags: review?(mhaigh)
Sorry, Finkle, but I still feel dumb.
tracking-fennec: ? → 41+
Comment on attachment 8628480 [details]
MozReview Request: Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh

https://reviewboard.mozilla.org/r/12385/#review10913

Ah that old chestnut, I've made this mistake before.
Attachment #8628480 - Flags: review?(mhaigh) → review+
Comment on attachment 8628480 [details]
MozReview Request: Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh

Approval Request Comment
[Feature/regressing bug #]: bug 864958
[User impact if declined]: Users will see a progress bar that is not the intended color (and looks pretty bad) in private browsing mode

[Describe test coverage new/current, TreeHerder]: Tested locally
[Risks and why]: Low - we're adding a call to retrieve the color from resources (rather than just using the color's ID). These are reliable methods so most likely any errors would be caught at compile time.

[String/UUID change made/needed]: None
Attachment #8628480 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/92eea1b8551a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8628480 [details]
MozReview Request: Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh

Approving for uplift to Aurora. Seems like a simple fix.
Attachment #8628480 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Backout 41, see bug 864958 comment 51 for motivations:
  https://hg.mozilla.org/releases/mozilla-aurora/rev/393e33ff18c4

I'll be backing out bug 864958 too so 41 will be unaffected.
tracking-fennec: 41+ → 42+
Tested with:
Device: Nexus 4 (Android 5.1)
Build: Firefox for Android 42.0a1 (2015-07-19)
Attachment #8628480 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.