Closed
Bug 1179403
Opened 7 years ago
Closed 7 years ago
Private browsing ToolbarProgressView too dark
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox41 unaffected, firefox42 verified, fennec42+)
RESOLVED
FIXED
Firefox 42
Tracking | Status | |
---|---|---|
firefox41 | --- | unaffected |
firefox42 | --- | verified |
fennec | 42+ | --- |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(3 files)
It should be private_browsing_purple - it uses that color in the color filter in code, but I'm not sure why it's not working. Implemented in bug 864958.
Assignee | ||
Comment 1•7 years ago
|
||
Track 41 to follow bug 864958 please.
Assignee: nobody → michael.l.comella
tracking-fennec: --- → ?
Assignee | ||
Comment 2•7 years ago
|
||
Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh
Attachment #8628480 -
Flags: review?(mhaigh)
Assignee | ||
Comment 3•7 years ago
|
||
Sorry, Finkle, but I still feel dumb.
Assignee | ||
Updated•7 years ago
|
tracking-fennec: ? → 41+
Comment 4•7 years ago
|
||
Comment on attachment 8628480 [details] MozReview Request: Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh https://reviewboard.mozilla.org/r/12385/#review10913 Ah that old chestnut, I've made this mistake before.
Attachment #8628480 -
Flags: review?(mhaigh) → review+
Assignee | ||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/92eea1b8551a
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8628480 [details] MozReview Request: Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh Approval Request Comment [Feature/regressing bug #]: bug 864958 [User impact if declined]: Users will see a progress bar that is not the intended color (and looks pretty bad) in private browsing mode [Describe test coverage new/current, TreeHerder]: Tested locally [Risks and why]: Low - we're adding a call to retrieve the color from resources (rather than just using the color's ID). These are reliable methods so most likely any errors would be caught at compile time. [String/UUID change made/needed]: None
Attachment #8628480 -
Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/92eea1b8551a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8628480 [details] MozReview Request: Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh Approving for uplift to Aurora. Seems like a simple fix.
Attachment #8628480 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•7 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/c6b17a2f6d98
status-firefox41:
--- → fixed
Assignee | ||
Comment 10•7 years ago
|
||
Backout 41, see bug 864958 comment 51 for motivations: https://hg.mozilla.org/releases/mozilla-aurora/rev/393e33ff18c4 I'll be backing out bug 864958 too so 41 will be unaffected.
tracking-fennec: 41+ → 42+
Comment 11•7 years ago
|
||
Tested with: Device: Nexus 4 (Android 5.1) Build: Firefox for Android 42.0a1 (2015-07-19)
Updated•7 years ago
|
Updated•7 years ago
|
Attachment #8628480 -
Flags: approval-mozilla-aurora+
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•