1179403 - Private browsing ToolbarProgressView too dark

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

It should be private_browsing_purple - it uses that color in the color filter in code, but I'm not sure why it's not working.

Implemented in bug 864958.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Track 41 to follow bug 864958 please.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh

Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Sorry, Finkle, but I still feel dumb.

Comment 4

[Martyn Haigh (:mhaigh)]

Comment on attachment 8628480 [details]
MozReview Request: Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh

https://reviewboard.mozilla.org/r/12385/#review10913

Ah that old chestnut, I've made this mistake before.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/92eea1b8551a

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8628480 [details]
MozReview Request: Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh

Approval Request Comment
[Feature/regressing bug #]: bug 864958
[User impact if declined]: Users will see a progress bar that is not the intended color (and looks pretty bad) in private browsing mode

[Describe test coverage new/current, TreeHerder]: Tested locally
[Risks and why]: Low - we're adding a call to retrieve the color from resources (rather than just using the color's ID). These are reliable methods so most likely any errors would be caught at compile time.

[String/UUID change made/needed]: None

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/92eea1b8551a

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8628480 [details]
MozReview Request: Bug 1179403 - Get the correct color for private browsing tint. r=mhaigh

Approving for uplift to Aurora. Seems like a simple fix.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c6b17a2f6d98

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Backout 41, see bug 864958 comment 51 for motivations:
  https://hg.mozilla.org/releases/mozilla-aurora/rev/393e33ff18c4

I'll be backing out bug 864958 too so 41 will be unaffected.

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-07-20-14-36-08.png

Tested with:
Device: Nexus 4 (Android 5.1)
Build: Firefox for Android 42.0a1 (2015-07-19)