1179407 - Private browsing toolbar text background fades to wrong color

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

Regression from bug 864958.

This is a side effect of using the FadedMultiColorTextView (or whatever it's called). The background at the right edge of the text is black, rather than the updated color in bug 864958.

See the attached screenshot and see the gap between the black and the grey.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1179407 - Replace toolbar fade color with placeholder_active_grey. r=mhaigh

Bug 1179407 - Replace toolbar fade color with placeholder_active_grey. r=mhaigh

The color is from the url_bar_entry_default_pb asset, which I eyedroppered the
color from.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Track 42 to match bug 864958 please.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot post changeset

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #2)
> Track 42 to match bug 864958 please.

Typo: this should be 41.

Comment 5

[Martyn Haigh (:mhaigh)]

Comment on attachment 8628409 [details]
MozReview Request: Bug 1179407 - Replace toolbar fade color with placeholder_active_grey. r=mhaigh

https://reviewboard.mozilla.org/r/12377/#review10915

Ship It!

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/bcc3546c2583

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8628409 [details]
MozReview Request: Bug 1179407 - Replace toolbar fade color with placeholder_active_grey. r=mhaigh

Approval Request Comment
[Feature/regressing bug #]: bug 864958
[User impact if declined]: Users will see an inconsistent toolbar background color when the url overflows.

[Describe test coverage new/current, TreeHerder]: Tested locally.
[Risks and why]: Low - we just do a color swap. Worst case - no build. Second worst - wrong color.

[String/UUID change made/needed]: None

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bcc3546c2583

Comment 9

[Kate Glazko]

Comment on attachment 8628409 [details]
MozReview Request: Bug 1179407 - Replace toolbar fade color with placeholder_active_grey. r=mhaigh

Approving for Uplift to Aurora, this patch has been in Central for several days. Low-risk.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ea6c6e697e9f

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Backout 41, see bug 864958 comment 51 for motivations:
  https://hg.mozilla.org/releases/mozilla-aurora/rev/4443917bb745

I'll be backing out bug 864958 too so 41 will be unaffected.

Comment 12

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-07-20-14-48-00.png

Verified as fixed using:
Device: Nexus 4 (Android 5.1)
Build: Firefox for Android 42.0a1 (2015-07-19)