Closed Bug 1179407 Opened 4 years ago Closed 4 years ago

Private browsing toolbar text background fades to wrong color

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
firefox41 --- unaffected
firefox42 --- verified
fennec 42+ ---

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(4 files)

Attached image Screenshot
Regression from bug 864958.

This is a side effect of using the FadedMultiColorTextView (or whatever it's called). The background at the right edge of the text is black, rather than the updated color in bug 864958.

See the attached screenshot and see the gap between the black and the grey.
Bug 1179407 - Replace toolbar fade color with placeholder_active_grey. r=mhaigh

The color is from the url_bar_entry_default_pb asset, which I eyedroppered the
color from.
Attachment #8628409 - Flags: review?(mhaigh)
Track 42 to match bug 864958 please.
Assignee: nobody → michael.l.comella
tracking-fennec: --- → ?
tracking-fennec: ? → 41+
(In reply to Michael Comella (:mcomella) from comment #2)
> Track 42 to match bug 864958 please.

Typo: this should be 41.
Comment on attachment 8628409 [details]
MozReview Request: Bug 1179407 - Replace toolbar fade color with placeholder_active_grey. r=mhaigh

https://reviewboard.mozilla.org/r/12377/#review10915

Ship It!
Attachment #8628409 - Flags: review?(mhaigh) → review+
Comment on attachment 8628409 [details]
MozReview Request: Bug 1179407 - Replace toolbar fade color with placeholder_active_grey. r=mhaigh

Approval Request Comment
[Feature/regressing bug #]: bug 864958
[User impact if declined]: Users will see an inconsistent toolbar background color when the url overflows.

[Describe test coverage new/current, TreeHerder]: Tested locally.
[Risks and why]: Low - we just do a color swap. Worst case - no build. Second worst - wrong color.

[String/UUID change made/needed]: None
Attachment #8628409 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/bcc3546c2583
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8628409 [details]
MozReview Request: Bug 1179407 - Replace toolbar fade color with placeholder_active_grey. r=mhaigh

Approving for Uplift to Aurora, this patch has been in Central for several days. Low-risk.
Attachment #8628409 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Backout 41, see bug 864958 comment 51 for motivations:
  https://hg.mozilla.org/releases/mozilla-aurora/rev/4443917bb745

I'll be backing out bug 864958 too so 41 will be unaffected.
tracking-fennec: 41+ → 42+
Verified as fixed using:
Device: Nexus 4 (Android 5.1)
Build: Firefox for Android 42.0a1 (2015-07-19)
Attachment #8628409 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.